Skip to content

tProxy needs a way to deal with TLV UserIdentity bigger than 32 bytes #399

@plebhash

Description

@plebhash

#295 reported an issue where tProxy was panicking whenever the Sv1 username (which later becomes TLV UserIdentity) is bigger than 32 bytes

#395 applied some temporary hotpatch, with a few compromises:

  • we do a lossy truncation of the stored user_identity copy of the username field of Sv1 mining.authorize, leaving room for collisions
  • this truncation happens with a warning, which is triggered even if extension 0x0002 is not active, leaving room for confusing UX

These compromises should be replaced with more sustainable long-term solutions.

We should also define clearer boundaries for:

  • the config user_identity used for OpenExtendedMiningChannel
  • the Sv1 worker name from mining.authorize
  • the 32-byte TLV UserIdentity used by extension 0x0002

relevant note: #295 (comment)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    Status

    Todo 📝

    Status

    Todo 📝

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions