NX experiment

.circleci/src/jobs/bench-packages.yml

@@ -6,7 +6,7 @@ steps:
   - git-shallow-clone/checkout_advanced:
       clone_options: '--depth 1 --verbose'
   - attach_workspace:
-      at: .
+      at: /tmp
   # if there is a base branch AND a PR number in parameters, benchmark packages against those
   # this happens when run against a PR
   - when:
@@ -56,6 +56,6 @@ steps:
             working_directory: scripts
             command: yarn bench-packages --upload
   - store_artifacts:
-      path: bench/packages/results.json
+      path: storybook/bench/packages/results.json
   - report-workflow-on-failure
   - cancel-workflow-on-failure

.circleci/src/jobs/bench-sandboxes.yml

@@ -12,12 +12,13 @@ steps:
   - git-shallow-clone/checkout_advanced:
       clone_options: '--depth 1 --verbose'
   - attach_workspace:
-      at: .
+      at: /tmp
   - run:
       name: Install sandbox dependencies
       command: |
+        corepack enable
         TEMPLATE=$(yarn get-template --cadence << pipeline.parameters.workflow >> --task bench)
-        cd sandbox/$(yarn get-sandbox-dir --template $TEMPLATE) && yarn
+        cd $(yarn get-sandbox-dir --template $TEMPLATE) && yarn
   - run:
       name: Running Bench
       command: yarn task --task bench --template $(yarn get-template --cadence << pipeline.parameters.workflow >> --task bench) --no-link --start-from=never --junit

.circleci/src/jobs/build.yml

@@ -8,10 +8,11 @@ steps:
   - restore_cache:
       name: Restore Yarn cache
       keys:
-        - build-yarn-2-cache-v5--{{ checksum "code/yarn.lock" }}--{{ checksum "scripts/yarn.lock" }}
+        - build-yarn-2-cache-v5--{{ checksum "yarn.lock" }}
   - run:
       name: Compile
       command: |
+        yarn
         yarn task --task compile --start-from=auto --no-link --debug
         git diff --exit-code
         yarn dedupe --check
@@ -22,24 +23,25 @@ steps:
         yarn local-registry --publish
   - report-workflow-on-failure
   - store_artifacts:
-      path: code/bench/esbuild-metafiles
+      path: storybook/code/bench/esbuild-metafiles
   - save_cache:
       name: Save Yarn cache
-      key: build-yarn-2-cache-v5--{{ checksum "code/yarn.lock" }}--{{ checksum "scripts/yarn.lock" }}
+      key: build-yarn-2-cache-v5--{{ checksum "yarn.lock" }}
       paths:
         - ~/.yarn/berry/cache
   - persist_to_workspace:
-      root: .
+      root: /tmp
       paths:
-        - code/node_modules
-        - code/addons
-        - scripts/node_modules
-        - code/bench
-        - code/examples
-        - code/frameworks
-        - code/lib
-        - code/core
-        - code/builders
-        - code/renderers
-        - code/presets
-        - .verdaccio-cache
+        - storybook/node_modules
+        - storybook/code/node_modules
+        - storybook/code/addons
+        - storybook/scripts/node_modules
+        - storybook/code/bench
+        - storybook/code/examples
+        - storybook/code/frameworks
+        - storybook/code/lib
+        - storybook/code/core
+        - storybook/code/builders
+        - storybook/code/renderers
+        - storybook/code/presets
+        - storybook/.verdaccio-cache

.circleci/src/jobs/check-sandboxes.yml

@@ -12,16 +12,17 @@ steps:
   - git-shallow-clone/checkout_advanced:
       clone_options: '--depth 1 --verbose'
   - attach_workspace:
-      at: .
+      at: /tmp
   - run:
       name: Install sandbox dependencies
       command: |
+        corepack enable
         TEMPLATE=$(yarn get-template --cadence << pipeline.parameters.workflow >> --task check-sandbox)
-        cd sandbox/$(yarn get-sandbox-dir --template $TEMPLATE) && yarn
+        cd $(yarn get-sandbox-dir --template $TEMPLATE) && yarn
   - run:
       name: Type check Sandboxes
       command: yarn task --task check-sandbox --template $(yarn get-template --cadence << pipeline.parameters.workflow >> --task check-sandbox) --no-link --start-from=never --junit
   - report-workflow-on-failure:
       template: $(yarn get-template --cadence << pipeline.parameters.workflow >> --task check-sandbox)
   - store_test_results:
-      path: test-results
+      path: storybook/test-results

.circleci/src/jobs/check.yml

@@ -11,10 +11,11 @@ steps:
   - restore_cache:
       name: Restore Yarn cache
       keys:
-        - build-yarn-2-cache-v5--{{ checksum "code/yarn.lock" }}--{{ checksum "scripts/yarn.lock" }}
+        - build-yarn-2-cache-v5--{{ checksum "yarn.lock" }}
   - run:
       name: Compile
       command: |
+        yarn
         yarn task --task compile --start-from=auto --no-link --debug
   - run:
       name: Check

.circleci/src/jobs/chromatic-internal-storybook.yml

@@ -9,11 +9,11 @@ steps:
   # switched this to the CircleCI helper to get the full git history for TurboSnap
   - checkout
   - attach_workspace:
-      at: .
+      at: /tmp
   - run:
       name: Running Chromatic
       command: yarn storybook:ui:chromatic
       working_directory: code
   - report-workflow-on-failure
   - store_test_results:
-      path: test-results
+      path: storybook/test-results

.circleci/src/jobs/chromatic-sandboxes.yml

@@ -11,16 +11,19 @@ parallelism: << parameters.parallelism >>
 steps:
   - checkout
   - attach_workspace:
-      at: .
+      at: /tmp
   - run:
       name: Install sandbox dependencies
+      # chromatic can only run in a git directory
       command: |
+        corepack enable
+        cp /tmp/storybook-sandboxes /tmp/storybook/sandbox -r --remove-destination
         TEMPLATE=$(yarn get-template --cadence << pipeline.parameters.workflow >> --task chromatic)
-        cd sandbox/$(yarn get-sandbox-dir --template $TEMPLATE) && yarn
+        cd $(STORYBOOK_SANDBOX_ROOT=./sandbox yarn get-sandbox-dir --template $TEMPLATE) && yarn
   - run:
       name: Running Chromatic
-      command: yarn task --task chromatic --template $(yarn get-template --cadence << pipeline.parameters.workflow >> --task chromatic) --no-link --start-from=never --junit
+      command: STORYBOOK_SANDBOX_ROOT=./sandbox yarn task --task chromatic --template $(yarn get-template --cadence << pipeline.parameters.workflow >> --task chromatic) --no-link --start-from=never --junit
   - report-workflow-on-failure:
       template: $(yarn get-template --cadence << pipeline.parameters.workflow >> --task chromatic)
   - store_test_results:
-      path: test-results
+      path: storybook/test-results

.circleci/src/jobs/coverage.yml

@@ -6,6 +6,6 @@ steps:
   - git-shallow-clone/checkout_advanced:
       clone_options: '--depth 1 --verbose'
   - attach_workspace:
-      at: .
+      at: /tmp
   - codecov/upload
   - report-workflow-on-failure

.circleci/src/jobs/create-sandboxes.yml

@@ -12,7 +12,7 @@ steps:
   - git-shallow-clone/checkout_advanced:
       clone_options: '--depth 1 --verbose'
   - attach_workspace:
-      at: .
+      at: /tmp
   - run:
       name: Setup Corepack
       command: |
@@ -31,15 +31,15 @@ steps:
         if [[ $TEMPLATE != bench/* ]]; then
           yarn --cwd scripts jiti ./event-log-checker.ts build $TEMPLATE
         fi
-        cd sandbox/$(yarn get-sandbox-dir --template $TEMPLATE) && rm -rf node_modules
+        cd $(yarn get-sandbox-dir --template $TEMPLATE) && rm -rf node_modules
       environment:
         STORYBOOK_TELEMETRY_DEBUG: 1
         STORYBOOK_TELEMETRY_URL: 'http://localhost:6007/event-log'
   - report-workflow-on-failure:
       template: $(yarn get-template --cadence << pipeline.parameters.workflow >> --task sandbox)
   - persist_to_workspace:
-      root: .
+      root: /tmp
       paths:
-        - sandbox/**
+          storybook-sandboxes/**
   - store_test_results:
-      path: test-results
+      path: storybook/test-results

.circleci/src/jobs/e2e-dev.yml

@@ -12,12 +12,13 @@ steps:
   - git-shallow-clone/checkout_advanced:
       clone_options: '--depth 1 --verbose'
   - attach_workspace:
-      at: .
+      at: /tmp
   - run:
       name: Install sandbox dependencies
       command: |
+        corepack enable
         TEMPLATE=$(yarn get-template --cadence << pipeline.parameters.workflow >> --task e2e-tests-dev)
-        cd sandbox/$(yarn get-sandbox-dir --template $TEMPLATE) && yarn
+        cd $(yarn get-sandbox-dir --template $TEMPLATE) && yarn
   - run:
       name: Running E2E Tests
       # TEST_FILES should include all relevant test files, in this case we use the default playwright pattern
@@ -29,7 +30,7 @@ steps:
   - report-workflow-on-failure:
       template: $(yarn get-template --cadence << pipeline.parameters.workflow >> --task e2e-tests-dev)
   - store_test_results:
-      path: test-results
+      path: storybook/test-results
   - store_artifacts: # this is where playwright puts more complex stuff
-      path: code/playwright-results/
+      path: storybook/code/playwright-results/
       destination: playwright

.circleci/src/jobs/e2e-production.yml

@@ -12,12 +12,13 @@ steps:
   - git-shallow-clone/checkout_advanced:
       clone_options: '--depth 1 --verbose'
   - attach_workspace:
-      at: .
+      at: /tmp
   - run:
       name: Install sandbox dependencies
       command: |
+        corepack enable
         TEMPLATE=$(yarn get-template --cadence << pipeline.parameters.workflow >> --task e2e-tests)
-        cd sandbox/$(yarn get-sandbox-dir --template $TEMPLATE) && yarn
+        cd $(yarn get-sandbox-dir --template $TEMPLATE) && yarn
   - run:
       name: Running E2E Tests
       # TEST_FILES should include all relevant test files, in this case we use the default playwright pattern
@@ -29,7 +30,7 @@ steps:
   - report-workflow-on-failure:
       template: $(yarn get-template --cadence << pipeline.parameters.workflow >> --task e2e-tests)
   - store_test_results:
-      path: test-results
+      path: storybook/test-results
   - store_artifacts: # this is where playwright puts more complex stuff
-      path: code/playwright-results/
+      path: storybook/code/playwright-results/
       destination: playwright

.circleci/src/jobs/e2e-ui-vitest-3.yml

@@ -6,7 +6,7 @@ steps:
   - git-shallow-clone/checkout_advanced:
       clone_options: '--depth 1 --verbose'
   - attach_workspace:
-      at: .
+      at: /tmp
   - run:
       name: Install dependencies
       command: yarn install --no-immutable
@@ -18,8 +18,8 @@ steps:
       command: yarn playwright-e2e
       working_directory: test-storybooks/portable-stories-kitchen-sink/react-vitest-3
   - store_test_results:
-      path: test-results
+      path: storybook/test-results
   - store_artifacts:
-      path: test-storybooks/portable-stories-kitchen-sink/react-vitest-3/test-results/
+      path: storybook/test-storybooks/portable-stories-kitchen-sink/react-vitest-3/test-results/
       destination: playwright
   - report-workflow-on-failure

.circleci/src/jobs/e2e-ui.yml

@@ -6,7 +6,7 @@ steps:
   - git-shallow-clone/checkout_advanced:
       clone_options: '--depth 1 --verbose'
   - attach_workspace:
-      at: .
+      at: /tmp
   - run:
       name: Install dependencies
       command: yarn install --no-immutable
@@ -18,8 +18,8 @@ steps:
       command: yarn playwright-e2e
       working_directory: test-storybooks/portable-stories-kitchen-sink/react
   - store_test_results:
-      path: test-results
+      path: storybook/test-results
   - store_artifacts:
-      path: test-storybooks/portable-stories-kitchen-sink/react/test-results/
+      path: storybook/test-storybooks/portable-stories-kitchen-sink/react/test-results/
       destination: playwright
   - report-workflow-on-failure

.circleci/src/jobs/knip.yml

@@ -6,7 +6,7 @@ steps:
   - git-shallow-clone/checkout_advanced:
       clone_options: '--depth 1 --verbose'
   - attach_workspace:
-      at: .
+      at: /tmp
   - run:
       name: Knip
       command: |

.circleci/src/jobs/lint.yml

@@ -6,7 +6,7 @@ steps:
   - git-shallow-clone/checkout_advanced:
       clone_options: '--depth 1 --verbose'
   - attach_workspace:
-      at: .
+      at: /tmp
   - run:
       name: Lint
       command: |

.circleci/src/jobs/pretty-docs.yml

@@ -1,5 +1,5 @@
 executor:
-  class: medium
+  class: medium+
   name: sb_node_22_classic
 
 steps:
@@ -8,15 +8,14 @@ steps:
   - restore_cache:
       name: Restore Yarn cache
       keys:
-        - prettydocs-yarn-2-cache-v8--{{ checksum "code/yarn.lock" }}--{{ checksum "scripts/yarn.lock" }}
+        - prettydocs-yarn-2-cache-v8--{{ checksum "yarn.lock" }}
   - run:
       name: Install
       command: |
-        cd scripts
         yarn install
   - save_cache:
       name: Save Yarn cache
-      key: prettydocs-yarn-2-cache-v8--{{ checksum "code/yarn.lock" }}--{{ checksum "scripts/yarn.lock" }}
+      key: prettydocs-yarn-2-cache-v8--{{ checksum "yarn.lock" }}
       paths:
         - ~/.yarn/berry/cache
   - run:

.circleci/src/jobs/script-checks.yml

@@ -4,7 +4,7 @@ steps:
   - git-shallow-clone/checkout_advanced:
       clone_options: '--depth 1 --verbose'
   - attach_workspace:
-      at: .
+      at: /tmp
   - run:
       name: Check parallelism count
       command: |
@@ -21,6 +21,6 @@ steps:
         cd scripts
         yarn test --coverage
   - store_test_results:
-      path: scripts/junit.xml
+      path: storybook/scripts/junit.xml
   - report-workflow-on-failure
   - cancel-workflow-on-failure

.circleci/src/jobs/smoke-test-sandboxes.yml

@@ -12,11 +12,11 @@ steps:
   - git-shallow-clone/checkout_advanced:
       clone_options: '--depth 1 --verbose'
   - attach_workspace:
-      at: .
+      at: /tmp
   - run:
       name: Smoke Testing Sandboxes
       command: yarn task --task smoke-test --template $(yarn get-template --cadence << pipeline.parameters.workflow >> --task smoke-test) --no-link --start-from=never --junit
   - report-workflow-on-failure:
       template: $(yarn get-template --cadence << pipeline.parameters.workflow >> --task smoke-test)
   - store_test_results:
-      path: test-results
+      path: storybook/test-results

.circleci/src/jobs/stories-tests.yml

@@ -6,14 +6,14 @@ steps:
   - git-shallow-clone/checkout_advanced:
       clone_options: --depth 1 --verbose
   - attach_workspace:
-      at: .
+      at: /tmp
   - run:
       command: |
         cd code
         TEST_FILES=$(circleci tests glob "**/*.{stories}.{ts,tsx,js,jsx,cjs}" | sed "/^e2e-tests\//d" | sed "/^node_modules\//d")
         echo "$TEST_FILES" | circleci tests run --command="xargs yarn test --reporter=junit --reporter=default --outputFile=../test-results/junit-${CIRCLE_NODE_INDEX}.xml" --verbose
       name: Run tests
   - store_test_results:
-      path: test-results
+      path: storybook/test-results
   - report-workflow-on-failure
   - cancel-workflow-on-failure