-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
Build: Make the git root the yarn workspace root #33079
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 148 commits
1c1ffd8
2389161
87248f1
4ed1f03
8315eca
60585da
3395ec4
90a98b1
191f62f
27f0df8
3f41c5c
450a597
40546dc
c5b8f6f
4b0c692
1a4bd4b
3c6b896
8fefecc
201ec1d
7ec3ddf
8cbbe64
eb15265
6bd1298
c1aad54
9b026ad
8d8340f
4541ed1
f156b7c
f043740
94e0fb1
0c7f833
97703ea
21f36b4
22d4943
c1f1d14
7f591cb
5b5707d
29e4e62
d58145b
b725865
5b8cc5d
43b867d
31b66f3
ada652d
d117b55
fc43625
64445d9
5c69f66
b95a58c
6510728
1dafa76
87aeefa
749d6e7
96a5985
b1da823
9432c9d
f4a7b3f
343fc35
34a86cb
efd1c71
48062e6
7480c35
4b48623
bfa1030
df5833b
9070aa0
f4f1400
b461426
aa067dd
fda45b4
84b4c6f
aa22dec
7954641
e4a4e44
f9f9013
0b0d57c
73f17ad
25f522c
603ae01
2e4f5fe
ee68eed
da41a2b
26037e4
cd89923
981cb9f
20b6013
5fc9f20
8a14b20
178fba9
c4c70a1
1d4b4c6
344e2d6
9f30b36
c94550f
117269b
125b82f
bbfdc18
cc98663
ae66276
d603f3b
8015e38
4cdcbf2
1cefa8a
8aa1061
9933662
3f32b93
065723e
39bf94a
a660e75
84efc7c
caa4293
403d286
ff88872
561c6a2
dc21f51
24a2fcf
24f5f1a
3c5df2d
1047610
1ea7956
1d7ed0a
c0b2f83
2956855
c601e3a
8bcf839
6d24960
dea058e
15211b2
80af299
df4a27c
5205f7e
058fcd3
b4dd932
8a07044
e8ecfd6
d450284
c19f881
0eda2f9
f37eaf4
0bcff4b
7955c88
bef07e7
86ecf6e
3f52a5a
ca872c3
a9483c7
38d10a7
07d59d1
1ead2a8
7dd976b
74699b7
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| STORYBOOK_DISABLE_TELEMETRY=true | ||
| IN_STORYBOOK_SANDBOX=true | ||
| NX_RUN=true | ||
| # can be a relative path like ../storybook-sandbox | ||
| SANDBOX_ROOT=../storybook-sandboxes |
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,28 @@ | ||||||
| name: nx | ||||||
|
|
||||||
| on: | ||||||
| push: | ||||||
| pull_request: | ||||||
|
|
||||||
| permissions: | ||||||
| actions: read | ||||||
| contents: read | ||||||
|
|
||||||
| jobs: | ||||||
| nx: | ||||||
| runs-on: ubuntu-latest | ||||||
| steps: | ||||||
| - uses: actions/checkout@v4 | ||||||
| with: | ||||||
| filter: tree:0 | ||||||
| fetch-depth: 0 | ||||||
| - run: npx nx@latest start-ci-run --distribute-on="20 my-linux-extra-large-plus-js" --stop-agents-after="check,knip,test,pretty-docs,lint,test,sandbox,build-sandbox,e2e-tests,e2e-tests-dev,test-runner,vitest-integration,check-sandbox,e2e-ui,jest,cypress" | ||||||
| - uses: actions/setup-node@v4 | ||||||
| with: | ||||||
| node-version: 22 | ||||||
| cache: 'yarn' | ||||||
| - run: yarn install --immutable | ||||||
| - uses: nrwl/nx-set-shas@v4 | ||||||
| - run: yarn nx run-many --parallel=1 -t check,knip,test,pretty-docs,lint,test,sandbox,build-sandbox,e2e-tests,e2e-tests-dev,test-runner,vitest-integration,check-sandbox,e2e-ui,jest,cypress -c production -p="tag:ci:normal" | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. REGRESSION: Remove duplicate The targets list includes - - run: yarn nx run-many --parallel=1 -t check,knip,test,pretty-docs,lint,test,sandbox,build-sandbox,e2e-tests,e2e-tests-dev,test-runner,vitest-integration,check-sandbox,e2e-ui,jest,cypress -c production -p="tag:ci:normal"
+ - run: yarn nx run-many --parallel=1 -t check,knip,test,pretty-docs,lint,sandbox,build-sandbox,e2e-tests,e2e-tests-dev,test-runner,vitest-integration,check-sandbox,e2e-ui,jest,cypress -c production -p="tag:ci:normal"📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||
| - run: yarn nx fix-ci | ||||||
| if: always() | ||||||
This file was deleted.
| Original file line number | Diff line number | Diff line change | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,52 @@ | ||||||||||||||||||
| common-js-init-steps: &common-js-init-steps | ||||||||||||||||||
| - name: Checkout | ||||||||||||||||||
| uses: 'nrwl/nx-cloud-workflows/v5/workflow-steps/checkout/main.yaml' | ||||||||||||||||||
| - name: Restore Node Modules Cache | ||||||||||||||||||
| uses: 'nrwl/nx-cloud-workflows/v5/workflow-steps/cache/main.yaml' | ||||||||||||||||||
| inputs: | ||||||||||||||||||
| key: 'package-lock.json|yarn.lock|pnpm-lock.yaml|patches/**|.yarn/patches/**' | ||||||||||||||||||
| paths: 'node_modules' | ||||||||||||||||||
| base-branch: 'next' | ||||||||||||||||||
| - name: Restore Browser Binary Cache | ||||||||||||||||||
| uses: 'nrwl/nx-cloud-workflows/v5/workflow-steps/cache/main.yaml' | ||||||||||||||||||
| inputs: | ||||||||||||||||||
| key: 'package-lock.json|yarn.lock|pnpm-lock.yaml|"browsers"' | ||||||||||||||||||
| paths: | | ||||||||||||||||||
| '../.cache/Cypress' | ||||||||||||||||||
| base-branch: 'next' | ||||||||||||||||||
| - name: Install Node | ||||||||||||||||||
| uses: 'nrwl/nx-cloud-workflows/v5/workflow-steps/install-node/main.yaml' | ||||||||||||||||||
| - name: Install Node Modules | ||||||||||||||||||
| uses: 'nrwl/nx-cloud-workflows/v5/workflow-steps/install-node-modules/main.yaml' | ||||||||||||||||||
| - name: Install Browsers (if needed) | ||||||||||||||||||
| uses: 'nrwl/nx-cloud-workflows/v5/workflow-steps/install-browsers/main.yaml' | ||||||||||||||||||
|
|
||||||||||||||||||
| launch-templates: | ||||||||||||||||||
| linux-small-js: | ||||||||||||||||||
| resource-class: 'docker_linux_amd64/small' | ||||||||||||||||||
| image: 'ubuntu22.04-node20.19-v2' | ||||||||||||||||||
| init-steps: *common-js-init-steps | ||||||||||||||||||
| linux-medium-js: | ||||||||||||||||||
| resource-class: 'docker_linux_amd64/medium' | ||||||||||||||||||
| image: 'ubuntu22.04-node20.19-v2' | ||||||||||||||||||
| init-steps: *common-js-init-steps | ||||||||||||||||||
| linux-medium-plus-js: | ||||||||||||||||||
| resource-class: 'docker_linux_amd64/medium+' | ||||||||||||||||||
| image: 'ubuntu22.04-node20.19-v2' | ||||||||||||||||||
| init-steps: *common-js-init-steps | ||||||||||||||||||
| linux-large-js: | ||||||||||||||||||
| resource-class: 'docker_linux_amd64/large' | ||||||||||||||||||
| image: 'ubuntu22.04-node20.19-v2' | ||||||||||||||||||
| init-steps: *common-js-init-steps | ||||||||||||||||||
| linux-large-plus-js: | ||||||||||||||||||
| resource-class: 'docker_linux_amd64/large+' | ||||||||||||||||||
| image: 'ubuntu22.04-node20.19-v2' | ||||||||||||||||||
| init-steps: *common-js-init-steps | ||||||||||||||||||
| linux-extra-large-js: | ||||||||||||||||||
| resource-class: 'docker_linux_amd64/extra_large' | ||||||||||||||||||
| image: 'ubuntu22.04-node20.19-v2' | ||||||||||||||||||
| init-steps: *common-js-init-steps | ||||||||||||||||||
| my-linux-extra-large-plus-js: | ||||||||||||||||||
| resource-class: 'docker_linux_amd64/extra_large+' | ||||||||||||||||||
| image: 'ubuntu22.04-node20.19-v2' | ||||||||||||||||||
| init-steps: *common-js-init-steps | ||||||||||||||||||
|
Comment on lines
+49
to
+52
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fix inconsistent template naming. The template Apply this diff to align naming: - my-linux-extra-large-plus-js:
+ linux-extra-large-plus-js:
resource-class: 'docker_linux_amd64/extra_large+'
image: 'ubuntu22.04-node20.19-v2'
init-steps: *common-js-init-steps📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||||||||||||||
Uh oh!
There was an error while loading. Please reload this page.