Skip to content
Closed
Show file tree
Hide file tree
Changes from 148 commits
Commits
Show all changes
151 commits
Select commit Hold shift + click to select a range
1c1ffd8
Make the git root the yarn workspace root
kasperpeulen Nov 18, 2025
2389161
Move nx to the root
kasperpeulen Nov 18, 2025
87248f1
Fix checksums
kasperpeulen Nov 18, 2025
4ed1f03
run yarn
kasperpeulen Nov 18, 2025
8315eca
More fixes
kasperpeulen Nov 18, 2025
60585da
dedupe
kasperpeulen Nov 18, 2025
3395ec4
feat(nx-cloud): setup nx cloud workspace
kasperpeulen Nov 19, 2025
90a98b1
Merge pull request #33093 from storybookjs/feat/nx-cloud/setup
kasperpeulen Nov 19, 2025
191f62f
Enable nx distributed tasks
kasperpeulen Nov 19, 2025
27f0df8
Enable nx distributed tasks
kasperpeulen Nov 19, 2025
3f41c5c
Enable nx distributed tasks
kasperpeulen Nov 19, 2025
450a597
Enable nx distributed tasks
kasperpeulen Nov 19, 2025
40546dc
Run on every push
kasperpeulen Nov 19, 2025
c5b8f6f
Fix
kasperpeulen Nov 19, 2025
4b0c692
Add pretty docs
kasperpeulen Nov 19, 2025
1a4bd4b
Add cache true
kasperpeulen Nov 19, 2025
3c6b896
Add node_modules to cache
kasperpeulen Nov 19, 2025
8fefecc
Fix lint
kasperpeulen Nov 19, 2025
201ec1d
Make it faster
kasperpeulen Nov 19, 2025
7ec3ddf
Fix test command
kasperpeulen Nov 19, 2025
8cbbe64
Fix package.json
kasperpeulen Nov 19, 2025
eb15265
Make test succeed
kasperpeulen Nov 19, 2025
6bd1298
Add check command
kasperpeulen Nov 19, 2025
c1aad54
Fix depends on
kasperpeulen Nov 19, 2025
9b026ad
Install jiti
kasperpeulen Nov 19, 2025
8d8340f
Fix esbuild path
kasperpeulen Nov 19, 2025
4541ed1
Fix yarn.lock
kasperpeulen Nov 19, 2025
f156b7c
Fix chromatic build
kasperpeulen Nov 19, 2025
f043740
Fix jiti
kasperpeulen Nov 19, 2025
94e0fb1
Fix jiti?
kasperpeulen Nov 19, 2025
0c7f833
Fix deps
kasperpeulen Nov 20, 2025
97703ea
Fix check finally
kasperpeulen Nov 20, 2025
21f36b4
Fix check finally
kasperpeulen Nov 20, 2025
22d4943
Fix check
kasperpeulen Nov 20, 2025
c1f1d14
Fix
kasperpeulen Nov 20, 2025
7f591cb
Add sandboxes to nx cloud
kasperpeulen Nov 20, 2025
5b5707d
Make it faster
kasperpeulen Nov 20, 2025
29e4e62
Fix
kasperpeulen Nov 20, 2025
d58145b
Only ci-daily
kasperpeulen Nov 20, 2025
b725865
Run chromatic
kasperpeulen Nov 20, 2025
5b8cc5d
Run chromatic
kasperpeulen Nov 20, 2025
43b867d
Fix job
kasperpeulen Nov 20, 2025
31b66f3
Fix job
kasperpeulen Nov 20, 2025
ada652d
Fix run-registry
kasperpeulen Nov 20, 2025
d117b55
Fix
kasperpeulen Nov 20, 2025
fc43625
Run e2e-tests
kasperpeulen Nov 20, 2025
64445d9
Fix
kasperpeulen Nov 20, 2025
5c69f66
Fix
kasperpeulen Nov 21, 2025
b95a58c
Fix
kasperpeulen Nov 21, 2025
6510728
Fix knip
kasperpeulen Nov 21, 2025
1dafa76
Fix e2e tests
kasperpeulen Nov 21, 2025
87aeefa
Fix e2e tests
kasperpeulen Nov 21, 2025
749d6e7
Run scripts and root as well
kasperpeulen Nov 21, 2025
96a5985
Fix prodution config
kasperpeulen Nov 21, 2025
b1da823
Fix never to never run dependent tasks
kasperpeulen Nov 21, 2025
9432c9d
Add check-sandbox
kasperpeulen Nov 21, 2025
f4a7b3f
More
kasperpeulen Nov 21, 2025
343fc35
Fix never
kasperpeulen Nov 21, 2025
34a86cb
Add env variables
kasperpeulen Nov 21, 2025
efd1c71
Fix error message
kasperpeulen Nov 21, 2025
48062e6
Fix
kasperpeulen Nov 21, 2025
7480c35
Fix sandbox parts
kasperpeulen Nov 21, 2025
4b48623
Fix ports
kasperpeulen Nov 21, 2025
bfa1030
Fix nx
kasperpeulen Nov 21, 2025
df5833b
Fix knip
kasperpeulen Nov 21, 2025
9070aa0
Fix projects
kasperpeulen Nov 21, 2025
f4f1400
Fix yarn.lock
kasperpeulen Nov 21, 2025
b461426
Fix e2e tests
kasperpeulen Nov 21, 2025
aa067dd
Fix e2e tests
kasperpeulen Nov 21, 2025
fda45b4
Fix this shit
kasperpeulen Nov 21, 2025
84b4c6f
Add allmost everything to nx
kasperpeulen Nov 21, 2025
aa22dec
Add test-storybooks commands
kasperpeulen Nov 21, 2025
7954641
Fix
kasperpeulen Nov 21, 2025
e4a4e44
Fix sandbox command
kasperpeulen Nov 21, 2025
f9f9013
Fix yarn immutable
kasperpeulen Nov 21, 2025
0b0d57c
Fix stop-agents
kasperpeulen Nov 21, 2025
73f17ad
Add all test storybook tests
kasperpeulen Nov 21, 2025
25f522c
Some last fixes
kasperpeulen Nov 21, 2025
603ae01
Some last fixes
kasperpeulen Nov 21, 2025
2e4f5fe
Cleanup
kasperpeulen Nov 21, 2025
ee68eed
Remove svelte skeleton for now
kasperpeulen Nov 21, 2025
da41a2b
Don't store sandbox in nx cache
kasperpeulen Nov 21, 2025
26037e4
Log
kasperpeulen Nov 21, 2025
cd89923
Remove yarn cache as well
kasperpeulen Nov 21, 2025
981cb9f
Depend on run-registry
kasperpeulen Nov 21, 2025
20b6013
Wait on registry
kasperpeulen Nov 21, 2025
5fc9f20
Fix yarn issues
kasperpeulen Nov 21, 2025
8a14b20
Timeout
kasperpeulen Nov 21, 2025
178fba9
Better kill ports
kasperpeulen Nov 21, 2025
c4c70a1
Fix logic
kasperpeulen Nov 21, 2025
1d4b4c6
Better messing around
kasperpeulen Nov 21, 2025
344e2d6
Fix killing
kasperpeulen Nov 21, 2025
9f30b36
Never close verdaccio
kasperpeulen Nov 21, 2025
c94550f
Fix verdaccio
kasperpeulen Nov 21, 2025
117269b
Fix
kasperpeulen Nov 21, 2025
125b82f
Fix
kasperpeulen Nov 21, 2025
bbfdc18
Fix
kasperpeulen Nov 21, 2025
cc98663
Fix it for real
kasperpeulen Nov 22, 2025
ae66276
Use promise
kasperpeulen Nov 22, 2025
d603f3b
detach local-registry
kasperpeulen Nov 22, 2025
8015e38
Fix
kasperpeulen Nov 22, 2025
4cdcbf2
Fix
kasperpeulen Nov 22, 2025
1cefa8a
Fix
kasperpeulen Nov 22, 2025
8aa1061
Fix
kasperpeulen Nov 22, 2025
9933662
Fix
kasperpeulen Nov 22, 2025
3f32b93
Add call to setUnready function
kasperpeulen Nov 22, 2025
065723e
Try out
kasperpeulen Nov 22, 2025
39bf94a
Merge remote-tracking branch 'origin/kasper/ai-friendly-setup' into k…
kasperpeulen Nov 22, 2025
a660e75
Fix
kasperpeulen Nov 22, 2025
84efc7c
Fix prepare sandbox
kasperpeulen Nov 22, 2025
caa4293
Fix prepare sandbox
kasperpeulen Nov 22, 2025
403d286
Fix prepare sandbox
kasperpeulen Nov 22, 2025
ff88872
Debug better
kasperpeulen Nov 22, 2025
561c6a2
Fix
kasperpeulen Nov 22, 2025
dc21f51
Fix
kasperpeulen Nov 22, 2025
24a2fcf
More debugging
kasperpeulen Nov 22, 2025
24f5f1a
Fix
kasperpeulen Nov 22, 2025
3c5df2d
More log information
kasperpeulen Nov 22, 2025
1047610
debug further
kasperpeulen Nov 22, 2025
1ea7956
Update dependencies for prepare sandbox command
kasperpeulen Nov 22, 2025
1d7ed0a
Fix
kasperpeulen Nov 22, 2025
c0b2f83
Custom agent
kasperpeulen Nov 22, 2025
2956855
Start verdaccio in background
kasperpeulen Nov 22, 2025
c601e3a
Always start fresh
kasperpeulen Nov 22, 2025
8bcf839
Killing ports
kasperpeulen Nov 22, 2025
6d24960
Try differntly
kasperpeulen Nov 22, 2025
dea058e
Remove
kasperpeulen Nov 22, 2025
15211b2
Fix test
kasperpeulen Nov 22, 2025
80af299
Fuckers
kasperpeulen Nov 22, 2025
df4a27c
Wait longer
kasperpeulen Nov 22, 2025
5205f7e
Fix
kasperpeulen Nov 22, 2025
058fcd3
Merge remote-tracking branch 'origin/next' into kasper/ai-friendly-setup
kasperpeulen Nov 22, 2025
b4dd932
yarn.lock
kasperpeulen Nov 24, 2025
8a07044
Fix
kasperpeulen Nov 24, 2025
e8ecfd6
Merge remote-tracking branch 'origin/next' into kasper/ai-friendly-setup
kasperpeulen Nov 24, 2025
d450284
dedupe
kasperpeulen Nov 24, 2025
c19f881
Fix pretty docs
kasperpeulen Nov 24, 2025
0eda2f9
Fix pretty docs
kasperpeulen Nov 24, 2025
f37eaf4
Fix
kasperpeulen Nov 24, 2025
0bcff4b
Fix
kasperpeulen Nov 24, 2025
7955c88
Fix
kasperpeulen Nov 24, 2025
bef07e7
Fix
kasperpeulen Nov 24, 2025
86ecf6e
Revert
kasperpeulen Nov 24, 2025
3f52a5a
Fix
kasperpeulen Nov 24, 2025
ca872c3
Fix
kasperpeulen Nov 24, 2025
a9483c7
Run sandboxes outside of git repo in circle ci
kasperpeulen Nov 24, 2025
38d10a7
Fix
kasperpeulen Nov 24, 2025
07d59d1
Fix
kasperpeulen Nov 24, 2025
1ead2a8
Increase timeout
kasperpeulen Nov 24, 2025
7dd976b
Increase timeout
kasperpeulen Nov 24, 2025
74699b7
Fix circle ci
kasperpeulen Nov 24, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 16 additions & 10 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ executors:
docker:
- environment:
NODE_OPTIONS: --max_old_space_size=6144
SANDBOX_ROOT: ../storybook-sandboxes
image: cimg/node:18.20.3-browsers
parameters:
class:
Expand All @@ -56,6 +57,7 @@ executors:
docker:
- environment:
NODE_OPTIONS: --max_old_space_size=6144
SANDBOX_ROOT: ../storybook-sandboxes
image: cimg/node:22.15.0-browsers
parameters:
class:
Expand All @@ -74,6 +76,7 @@ executors:
docker:
- environment:
NODE_OPTIONS: --max_old_space_size=6144
SANDBOX_ROOT: ../storybook-sandboxes
image: cimg/node:22.15.0
parameters:
class:
Expand All @@ -92,6 +95,7 @@ executors:
docker:
- environment:
NODE_OPTIONS: --max_old_space_size=6144
SANDBOX_ROOT: ../storybook-sandboxes
image: mcr.microsoft.com/playwright:v1.52.0-noble
parameters:
class:
Expand Down Expand Up @@ -199,10 +203,11 @@ jobs:
clone_options: --depth 1 --verbose
- restore_cache:
keys:
- build-yarn-2-cache-v5--{{ checksum "code/yarn.lock" }}--{{ checksum "scripts/yarn.lock" }}
- build-yarn-2-cache-v5--{{ checksum "yarn.lock" }}
name: Restore Yarn cache
- run:
command: |
yarn
yarn task --task compile --start-from=auto --no-link --debug
git diff --exit-code
yarn dedupe --check
Expand All @@ -216,12 +221,13 @@ jobs:
- store_artifacts:
path: code/bench/esbuild-metafiles
- save_cache:
key: build-yarn-2-cache-v5--{{ checksum "code/yarn.lock" }}--{{ checksum "scripts/yarn.lock" }}
key: build-yarn-2-cache-v5--{{ checksum "yarn.lock" }}
name: Save Yarn cache
paths:
- ~/.yarn/berry/cache
- persist_to_workspace:
paths:
- node_modules
- code/node_modules
- code/addons
- scripts/node_modules
Expand All @@ -247,10 +253,11 @@ jobs:
workflow-name: << pipeline.parameters.workflow >>
- restore_cache:
keys:
- build-yarn-2-cache-v5--{{ checksum "code/yarn.lock" }}--{{ checksum "scripts/yarn.lock" }}
- build-yarn-2-cache-v5--{{ checksum "yarn.lock" }}
name: Restore Yarn cache
- run:
command: |
yarn
yarn task --task compile --start-from=auto --no-link --debug
name: Compile
- run:
Expand Down Expand Up @@ -527,22 +534,21 @@ jobs:
- cancel-workflow-on-failure
pretty-docs:
executor:
class: medium
class: medium+
name: sb_node_22_classic
steps:
- git-shallow-clone/checkout_advanced:
clone_options: --depth 1 --verbose
- restore_cache:
keys:
- prettydocs-yarn-2-cache-v8--{{ checksum "code/yarn.lock" }}--{{ checksum "scripts/yarn.lock" }}
- prettydocs-yarn-2-cache-v8--{{ checksum "yarn.lock" }}
name: Restore Yarn cache
- run:
command: |
cd scripts
yarn install
name: Install
command: |
yarn install
name: Install
- save_cache:
key: prettydocs-yarn-2-cache-v8--{{ checksum "code/yarn.lock" }}--{{ checksum "scripts/yarn.lock" }}
key: prettydocs-yarn-2-cache-v8--{{ checksum "yarn.lock" }}
name: Save Yarn cache
paths:
- ~/.yarn/berry/cache
Expand Down
4 changes: 2 additions & 2 deletions .circleci/src/jobs/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ steps:
- restore_cache:
name: Restore Yarn cache
keys:
- build-yarn-2-cache-v5--{{ checksum "code/yarn.lock" }}--{{ checksum "scripts/yarn.lock" }}
- build-yarn-2-cache-v5--{{ checksum "yarn.lock" }}
- run:
name: Compile
command: |
Expand All @@ -25,7 +25,7 @@ steps:
path: code/bench/esbuild-metafiles
- save_cache:
name: Save Yarn cache
key: build-yarn-2-cache-v5--{{ checksum "code/yarn.lock" }}--{{ checksum "scripts/yarn.lock" }}
key: build-yarn-2-cache-v5--{{ checksum "yarn.lock" }}
paths:
- ~/.yarn/berry/cache
- persist_to_workspace:
Expand Down
2 changes: 1 addition & 1 deletion .circleci/src/jobs/check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ steps:
- restore_cache:
name: Restore Yarn cache
keys:
- build-yarn-2-cache-v5--{{ checksum "code/yarn.lock" }}--{{ checksum "scripts/yarn.lock" }}
- build-yarn-2-cache-v5--{{ checksum "yarn.lock" }}
- run:
name: Compile
command: |
Expand Down
4 changes: 2 additions & 2 deletions .circleci/src/jobs/pretty-docs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,15 +8,15 @@ steps:
- restore_cache:
name: Restore Yarn cache
keys:
- prettydocs-yarn-2-cache-v8--{{ checksum "code/yarn.lock" }}--{{ checksum "scripts/yarn.lock" }}
- prettydocs-yarn-2-cache-v8--{{ checksum "yarn.lock" }}
- run:
name: Install
command: |
cd scripts
yarn install
- save_cache:
name: Save Yarn cache
key: prettydocs-yarn-2-cache-v8--{{ checksum "code/yarn.lock" }}--{{ checksum "scripts/yarn.lock" }}
key: prettydocs-yarn-2-cache-v8--{{ checksum "yarn.lock" }}
paths:
- ~/.yarn/berry/cache
- run:
Expand Down
5 changes: 5 additions & 0 deletions .env
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
STORYBOOK_DISABLE_TELEMETRY=true
IN_STORYBOOK_SANDBOX=true
NX_RUN=true
# can be a relative path like ../storybook-sandbox
SANDBOX_ROOT=../storybook-sandboxes
5 changes: 2 additions & 3 deletions .github/actions/setup-node-and-install/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,9 @@ runs:
with:
path: |
~/.yarn/berry/cache
key: yarn-v1-${{ hashFiles('scripts/yarn.lock') }}-${{ hashFiles('code/yarn.lock') }}
key: yarn-v1-${{ hashFiles('yarn.lock') }}
restore-keys: |
yarn-v1-${{ hashFiles('scripts/yarn.lock') }}-${{ hashFiles('code/yarn.lock') }}
yarn-v1-${{ hashFiles('scripts/yarn.lock') }}
yarn-v1-${{ hashFiles('yarn.lock') }}
yarn-v1

- name: Install script dependencies
Expand Down
28 changes: 28 additions & 0 deletions .github/workflows/nx.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
name: nx

on:
push:
pull_request:

permissions:
actions: read
contents: read

jobs:
nx:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
with:
filter: tree:0
fetch-depth: 0
- run: npx nx@latest start-ci-run --distribute-on="20 my-linux-extra-large-plus-js" --stop-agents-after="check,knip,test,pretty-docs,lint,test,sandbox,build-sandbox,e2e-tests,e2e-tests-dev,test-runner,vitest-integration,check-sandbox,e2e-ui,jest,cypress"
- uses: actions/setup-node@v4
with:
node-version: 22
cache: 'yarn'
- run: yarn install --immutable
- uses: nrwl/nx-set-shas@v4
- run: yarn nx run-many --parallel=1 -t check,knip,test,pretty-docs,lint,test,sandbox,build-sandbox,e2e-tests,e2e-tests-dev,test-runner,vitest-integration,check-sandbox,e2e-ui,jest,cypress -c production -p="tag:ci:normal"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

REGRESSION: Remove duplicate test target from run-many command.

The targets list includes test twice. A past review marked this as addressed, but the duplicate remains in both stop-agents-after (line 19) and the targets list (line 26).

-      - run: yarn nx run-many --parallel=1 -t check,knip,test,pretty-docs,lint,test,sandbox,build-sandbox,e2e-tests,e2e-tests-dev,test-runner,vitest-integration,check-sandbox,e2e-ui,jest,cypress -c production -p="tag:ci:normal"
+      - run: yarn nx run-many --parallel=1 -t check,knip,test,pretty-docs,lint,sandbox,build-sandbox,e2e-tests,e2e-tests-dev,test-runner,vitest-integration,check-sandbox,e2e-ui,jest,cypress -c production -p="tag:ci:normal"
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
- run: yarn nx run-many --parallel=1 -t check,knip,test,pretty-docs,lint,test,sandbox,build-sandbox,e2e-tests,e2e-tests-dev,test-runner,vitest-integration,check-sandbox,e2e-ui,jest,cypress -c production -p="tag:ci:normal"
- run: yarn nx run-many --parallel=1 -t check,knip,test,pretty-docs,lint,sandbox,build-sandbox,e2e-tests,e2e-tests-dev,test-runner,vitest-integration,check-sandbox,e2e-ui,jest,cypress -c production -p="tag:ci:normal"
🤖 Prompt for AI Agents
.github/workflows/nx.yml around lines 19 and 26: the run-many targets list
contains the "test" target twice (once in the stop-agents-after step and again
in the long targets list), so remove the duplicate occurrence so each target
appears only once; update the command on line 26 to omit the extra "test" entry
(or remove the one from line 19 if that is the intended single occurrence)
ensuring the run-many invocation lists unique targets.

- run: yarn nx fix-ci
if: always()
17 changes: 6 additions & 11 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -18,15 +18,13 @@ test-results
/.npmrc
tsconfig.vitest-temp.json

.env.local

# Yarn stuff
/**/.yarn/*
!/**/.yarn/releases
!/**/.yarn/plugins
!/**/.yarn/sdks
!/**/.yarn/versions
!/**/.yarn/patches
.yarn/cache/
.yarn/install-state.gz
.pnp.data.json
/**/.pnp.*
!/node_modules

# test-storybooks
test-storybooks/ember-cli/ember-output
Expand Down Expand Up @@ -55,15 +53,12 @@ code/playwright/.cache/
code/bench-results/

/packs
code/.nx/cache
code/.nx/workspace-data
.vite-inspect
.nx/cache
.nx/workspace-data
!**/fixtures/**/yarn.lock
code/core/report
node_modules/.svelte2tsx-language-server-files

*storybook.log

.junie
.junie
1 change: 0 additions & 1 deletion .ignore

This file was deleted.

52 changes: 52 additions & 0 deletions .nx/workflows/agents.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,52 @@
common-js-init-steps: &common-js-init-steps
- name: Checkout
uses: 'nrwl/nx-cloud-workflows/v5/workflow-steps/checkout/main.yaml'
- name: Restore Node Modules Cache
uses: 'nrwl/nx-cloud-workflows/v5/workflow-steps/cache/main.yaml'
inputs:
key: 'package-lock.json|yarn.lock|pnpm-lock.yaml|patches/**|.yarn/patches/**'
paths: 'node_modules'
base-branch: 'next'
- name: Restore Browser Binary Cache
uses: 'nrwl/nx-cloud-workflows/v5/workflow-steps/cache/main.yaml'
inputs:
key: 'package-lock.json|yarn.lock|pnpm-lock.yaml|"browsers"'
paths: |
'../.cache/Cypress'
base-branch: 'next'
- name: Install Node
uses: 'nrwl/nx-cloud-workflows/v5/workflow-steps/install-node/main.yaml'
- name: Install Node Modules
uses: 'nrwl/nx-cloud-workflows/v5/workflow-steps/install-node-modules/main.yaml'
- name: Install Browsers (if needed)
uses: 'nrwl/nx-cloud-workflows/v5/workflow-steps/install-browsers/main.yaml'

launch-templates:
linux-small-js:
resource-class: 'docker_linux_amd64/small'
image: 'ubuntu22.04-node20.19-v2'
init-steps: *common-js-init-steps
linux-medium-js:
resource-class: 'docker_linux_amd64/medium'
image: 'ubuntu22.04-node20.19-v2'
init-steps: *common-js-init-steps
linux-medium-plus-js:
resource-class: 'docker_linux_amd64/medium+'
image: 'ubuntu22.04-node20.19-v2'
init-steps: *common-js-init-steps
linux-large-js:
resource-class: 'docker_linux_amd64/large'
image: 'ubuntu22.04-node20.19-v2'
init-steps: *common-js-init-steps
linux-large-plus-js:
resource-class: 'docker_linux_amd64/large+'
image: 'ubuntu22.04-node20.19-v2'
init-steps: *common-js-init-steps
linux-extra-large-js:
resource-class: 'docker_linux_amd64/extra_large'
image: 'ubuntu22.04-node20.19-v2'
init-steps: *common-js-init-steps
my-linux-extra-large-plus-js:
resource-class: 'docker_linux_amd64/extra_large+'
image: 'ubuntu22.04-node20.19-v2'
init-steps: *common-js-init-steps
Comment on lines +49 to +52
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Fix inconsistent template naming.

The template my-linux-extra-large-plus-js breaks the naming convention used by all other templates. All others follow the pattern linux-{size}-js, but this one includes an unexpected my- prefix.

Apply this diff to align naming:

-  my-linux-extra-large-plus-js:
+  linux-extra-large-plus-js:
     resource-class: 'docker_linux_amd64/extra_large+'
     image: 'ubuntu22.04-node20.19-v2'
     init-steps: *common-js-init-steps
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
my-linux-extra-large-plus-js:
resource-class: 'docker_linux_amd64/extra_large+'
image: 'ubuntu22.04-node20.19-v2'
init-steps: *common-js-init-steps
linux-extra-large-plus-js:
resource-class: 'docker_linux_amd64/extra_large+'
image: 'ubuntu22.04-node20.19-v2'
init-steps: *common-js-init-steps
🤖 Prompt for AI Agents
In .nx/workflows/agents.yaml around lines 49 to 52, the agent key name
my-linux-extra-large-plus-js breaks the naming convention; rename the key to
linux-extra-large-plus-js to match the linux-{size}-js pattern and update any
references/usages of the old key elsewhere in the repo (workflows, docs, or
includes) so they point to the new name to avoid broken references.

File renamed without changes.
Loading
Loading