Skip to content

Conversation

@valentinpalkovic
Copy link
Contributor

@valentinpalkovic valentinpalkovic commented Oct 24, 2025

Closes #

What I did

Use rolldown and the rolldown DTS plugin to build DTS files.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook publish.yml --field pr=<PR_NUMBER>

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 24, 2025

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch valentin/use-rolldown-for-dts-generation

Comment @coderabbitai help to get the list of available commands and usage tips.

@valentinpalkovic valentinpalkovic added ci:normal build Internal-facing build tooling & test updates labels Oct 24, 2025
@nx-cloud
Copy link

nx-cloud bot commented Oct 24, 2025

View your CI Pipeline Execution ↗ for commit 4a23a97

Command Status Duration Result
nx run-many -t build --parallel=3 ✅ Succeeded 48s View ↗

☁️ Nx Cloud last updated this comment at 2025-10-29 10:57:41 UTC

@storybook-app-bot
Copy link

storybook-app-bot bot commented Oct 24, 2025

Package Benchmarks

Commit: 4a23a97, ran on 29 October 2025 at 10:47:12 UTC

The following packages have significant changes to their size or dependencies:

@storybook/addon-docs

Before After Difference
Dependency count 18 18 0
Self size 1.88 MB 1.87 MB 🎉 -15 KB 🎉
Dependency size 10.21 MB 10.21 MB 🚨 +76 B 🚨
Bundle Size Analyzer Link Link

storybook

Before After Difference
Dependency count 43 43 0
Self size 22.93 MB 21.27 MB 🎉 -1.66 MB 🎉
Dependency size 17.36 MB 17.36 MB 0 B
Bundle Size Analyzer Link Link

@storybook/ember

Before After Difference
Dependency count 191 191 0
Self size 17 KB 15 KB 🎉 -2 KB 🎉
Dependency size 28.61 MB 28.61 MB 🚨 +308 B 🚨
Bundle Size Analyzer Link Link

@storybook/nextjs

Before After Difference
Dependency count 532 532 0
Self size 749 KB 727 KB 🎉 -22 KB 🎉
Dependency size 58.50 MB 58.48 MB 🎉 -22 KB 🎉
Bundle Size Analyzer Link Link

@storybook/nextjs-vite

Before After Difference
Dependency count 124 124 0
Self size 3.83 MB 3.81 MB 🎉 -22 KB 🎉
Dependency size 21.54 MB 21.52 MB 🎉 -22 KB 🎉
Bundle Size Analyzer Link Link

@storybook/react-native-web-vite

Before After Difference
Dependency count 157 157 0
Self size 31 KB 31 KB 🚨 +25 B 🚨
Dependency size 22.92 MB 22.90 MB 🎉 -22 KB 🎉
Bundle Size Analyzer Link Link

@storybook/react-vite

Before After Difference
Dependency count 114 114 0
Self size 37 KB 37 KB 🎉 -227 B 🎉
Dependency size 19.48 MB 19.46 MB 🎉 -22 KB 🎉
Bundle Size Analyzer Link Link

@storybook/react-webpack5

Before After Difference
Dependency count 272 272 0
Self size 25 KB 25 KB 🚨 +41 B 🚨
Dependency size 43.46 MB 43.43 MB 🎉 -22 KB 🎉
Bundle Size Analyzer Link Link

@storybook/cli

Before After Difference
Dependency count 187 187 0
Self size 928 KB 928 KB 0 B
Dependency size 72.88 MB 71.22 MB 🎉 -1.66 MB 🎉
Bundle Size Analyzer Link Link

@storybook/codemod

Before After Difference
Dependency count 169 169 0
Self size 35 KB 35 KB 🚨 +35 B 🚨
Dependency size 69.31 MB 67.65 MB 🎉 -1.66 MB 🎉
Bundle Size Analyzer Link Link

create-storybook

Before After Difference
Dependency count 44 44 0
Self size 1.55 MB 1.55 MB 🎉 -30 B 🎉
Dependency size 40.29 MB 38.63 MB 🎉 -1.66 MB 🎉
Bundle Size Analyzer node node

@storybook/react

Before After Difference
Dependency count 2 2 0
Self size 627 KB 605 KB 🎉 -22 KB 🎉
Dependency size 28 KB 28 KB 🚨 +45 B 🚨
Bundle Size Analyzer Link Link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Internal-facing build tooling & test updates ci:normal

Projects

Status: Needs Discussion

Development

Successfully merging this pull request may close these issues.

3 participants