- 
          
- 
                Notifications
    You must be signed in to change notification settings 
- Fork 9.8k
Core: Dedupe aria-query and @testing-library/dom packages #32801
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Core: Dedupe aria-query and @testing-library/dom packages #32801
Conversation
| 📝 WalkthroughWalkthroughUpdates dependency constraints: relaxes  Changes
 Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Potential attention points: 
 ✨ Finishing touches🧪 Generate unit tests (beta)
 📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro ⛔ Files ignored due to path filters (1)
 📒 Files selected for processing (2)
 🚧 Files skipped from review as they are similar to previous changes (2)
 ⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
 Comment  | 
| View your CI Pipeline Execution ↗ for commit 5e75e42 
 ☁️ Nx Cloud last updated this comment at  | 
| Package BenchmarksCommit:  The following packages have significant changes to their size or dependencies: 
 | 
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 43 | 43 | 0 | 
| Self size | 24.15 MB | 23.50 MB | 🎉 -648 KB 🎉 | 
| Dependency size | 17.36 MB | 17.36 MB | 0 B | 
| Bundle Size Analyzer | Link | Link | 
@storybook/cli
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 187 | 187 | 0 | 
| Self size | 928 KB | 928 KB | 🚨 +84 B 🚨 | 
| Dependency size | 74.10 MB | 73.45 MB | 🎉 -647 KB 🎉 | 
| Bundle Size Analyzer | Link | Link | 
@storybook/codemod
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 169 | 169 | 0 | 
| Self size | 35 KB | 35 KB | 🚨 +42 B 🚨 | 
| Dependency size | 70.53 MB | 69.88 MB | 🎉 -648 KB 🎉 | 
| Bundle Size Analyzer | Link | Link | 
create-storybook
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 44 | 44 | 0 | 
| Self size | 1.55 MB | 1.55 MB | 0 B | 
| Dependency size | 41.51 MB | 40.86 MB | 🎉 -648 KB 🎉 | 
| Bundle Size Analyzer | node | node | 
@testing-library/dom was pulling in a fixed version of
[email protected]. Other references toaria-queryare using@^5.3.0(or similar), which means that many bundles included two full copies ofaria-query.This PR shaves ~200kb off
manager/globals-runtime.js(storybook runtime), and the same fromtest/index.js(storybook browser)What I did
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook publish.yml --field pr=<PR_NUMBER>Summary by CodeRabbit