-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
React: Implement manifests/component.json for React #32751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 57 commits
Commits
Show all changes
64 commits
Select commit
Hold shift + click to select a range
67d5780
generate code snippets from csf file
kasperpeulen 5efe183
Lot more cases
kasperpeulen 446abe5
Cleanup code
kasperpeulen ef96eff
Inline args in JSX
kasperpeulen 2d86537
More test examples
kasperpeulen 3738a60
Add extra tests
kasperpeulen 2442574
Fix type error
kasperpeulen 18aaaf4
Template.bind expressions
kasperpeulen 50ea146
Add componentManifestGenerator preset and implement for react
kasperpeulen addd229
Merge remote-tracking branch 'origin/10.1' into kasper/code-snippets
kasperpeulen 4ed3856
Fix types
kasperpeulen a449847
Update code/core/src/core-server/dev-server.ts
kasperpeulen 4ce972a
Update code/core/src/core-server/dev-server.ts
kasperpeulen 1599fac
Update code/core/src/core-server/build-static.ts
kasperpeulen 1bcd00b
Update code/core/src/core-server/build-static.ts
kasperpeulen bf9a49a
Improve dev server logic
kasperpeulen f2e3ddb
Merge remote-tracking branch 'origin/kasper/code-snippets' into kaspe…
kasperpeulen c0df22c
Add type
kasperpeulen 25b197e
Fix lint
kasperpeulen 18c671e
Use node logger
kasperpeulen 11ac914
Fix
kasperpeulen 98f121b
Add component name and tests
kasperpeulen bd91ab6
Fix typos
kasperpeulen d3f1940
Merge branch 'kasper/code-snippets' into kasper/manifest-component-name
kasperpeulen b865df9
Add component description to manifest
kasperpeulen 51cdfc7
Extract jsdoc tags
kasperpeulen 04cdc63
Make begin with props
kasperpeulen 1e84547
Remove redundant features fetch
kasperpeulen a6f6673
Apply feedback
kasperpeulen fd80c9d
Implement last feedback
kasperpeulen e2213c8
Restructure
kasperpeulen 55c37e5
Merge branch 'kasper/code-snippets' into kasper/props
kasperpeulen c7a1572
Fix type
kasperpeulen 46c5a6a
Fix name
kasperpeulen d9f9a3b
Fix check
kasperpeulen 0b83e62
Add export named handler and add tests for react-docgen
kasperpeulen 146a644
Fix
kasperpeulen 1e6dc13
Improve types
kasperpeulen 8224f40
Fix filename
kasperpeulen 0ed2b8c
Simplify memfs mock
kasperpeulen 22d12cc
Fix snapshot
kasperpeulen 9b18ad0
Fix format, use version number
kasperpeulen f9dd32e
Fix regex
kasperpeulen f6b154f
Fix type
kasperpeulen 36854cb
Fix lint
kasperpeulen f926862
Add error handling for build
kasperpeulen ca19b25
Typo
kasperpeulen 455fe3f
Fix children
kasperpeulen d1c6324
Fix unit tests
kasperpeulen c5311ef
Update code/renderers/react/src/componentManifest/generator.ts
kasperpeulen 80ea6a6
Fix unit tests
kasperpeulen 3825193
Add comment
kasperpeulen e4f7a57
Enable in UI
kasperpeulen 917db04
Adress review
kasperpeulen 6b39ffd
Trim the description
kasperpeulen 46a5714
Better error handling
kasperpeulen 4dfd30b
Address feedback
kasperpeulen 1181213
Filter out when we can not find a component name
kasperpeulen 0fd167e
Add a todo
kasperpeulen 99ff2b8
Make react-docgen dev dep
kasperpeulen 91d3927
Merge remote-tracking branch 'origin/10.1' into kasper/props
kasperpeulen ad233cb
Fix null and undefined values
kasperpeulen 787206f
Fix examples
kasperpeulen 39c7a71
Merge branch '10.1' into kasper/props
JReinhold File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 changes: 3 additions & 7 deletions
10
code/core/src/preview-api/modules/preview-web/render/mount-utils.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.