-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
React Native Web: Fix REACT_NATIVE_AND_RNW should detect vite builder #32718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
React Native Web: Fix REACT_NATIVE_AND_RNW should detect vite builder #32718
Conversation
📝 WalkthroughWalkthroughUpdated CLI project-type detection to route ProjectType.REACT_NATIVE_AND_RNW through the Vite builder path, aligning it with existing handling for REACT_NATIVE_WEB. No other branches or defaults were changed. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant User
participant CLI as CLI Detect
participant PT as ProjectType Resolver
participant Builder as CoreBuilder Selector
User->>CLI: run detect
CLI->>PT: determine ProjectType
PT-->>CLI: ProjectType value
alt Existing paths
CLI->>Builder: map type to builder (e.g., React, Next, Vite, etc.)
else New/Updated path
Note over CLI,Builder: New mapping
CLI->>Builder: if ProjectType == REACT_NATIVE_AND_RNW -> Vite
end
Builder-->>User: selected builder (Vite for RNW)
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes ✨ Finishing touches
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
code/core/src/cli/detect.ts (1)
136-138: Approve Vite builder for REACT_NATIVE_AND_RNW
Returns Vite for REACT_NATIVE_AND_RNW, matching REACT_NATIVE_WEB.
- Add a unit test for
detectBuildercoveringProjectType.REACT_NATIVE_AND_RNW.- Verify no existing projects rely on the previous prompt behavior.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
code/core/src/cli/detect.ts(1 hunks)
🧰 Additional context used
📓 Path-based instructions (4)
**/*.{js,jsx,json,html,ts,tsx,mjs}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
**/*.{js,jsx,json,html,ts,tsx,mjs}: Run Prettier formatting on changed files before committing
Run ESLint on changed files and fix all errors/warnings before committing (useyarn lint:js:cmd <file>)
Files:
code/core/src/cli/detect.ts
**/*.{ts,tsx,js,jsx,mjs}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Export functions from modules when they need to be unit-tested
Files:
code/core/src/cli/detect.ts
code/**/*.{ts,tsx,js,jsx,mjs}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
In application code, use Storybook loggers instead of
console.*(client code:storybook/internal/client-logger; server code:storybook/internal/node-logger)
Files:
code/core/src/cli/detect.ts
{code/**,scripts/**}/**/*.{ts,tsx,js,jsx,mjs}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Do not use
console.log,console.warn, orconsole.errordirectly unless in isolated files where importing loggers would significantly increase bundle size
Files:
code/core/src/cli/detect.ts
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: get-branch
- GitHub Check: Core Unit Tests, windows-latest
|
View your CI Pipeline Execution ↗ for commit 19d61e2
☁️ Nx Cloud last updated this comment at |
…_builder React Native Web: Fix REACT_NATIVE_AND_RNW should detect vite builder (cherry picked from commit a78bf07)
Closes #
What I did
When selecting both RN and RN Web you would get prompted about vite/webpack but vite should be detected since there is no template for rnw on webpack
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
tested by running locally
install and compile source in the monorepo then go to a react native project and run the local version of the create-storybook binary like this:
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook publish.yml --field pr=<PR_NUMBER>Summary by CodeRabbit