-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
Core: Add reentry guard to focus patch #32655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+24
−9
Merged
Changes from 7 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
8b67a74
fix(core): add reentrancy guard to focus patch
ia319 91a97f7
refactor(types): add type for Set
ia319 d991888
Merge branch 'next' into bug/32603
ia319 4f8575b
Merge branch 'next' into bug/32603
ia319 4d1922e
Merge branch 'next' into bug/32603
Sidnioulz 39ca566
Merge branch 'next' into bug/32603
yannbf ecdbd6b
Merge branch 'next' into bug/32603
yannbf 3f132a7
Merge branch 'storybookjs:next' into bug/32603
ia319 c1cf4c0
refactor (core): ensure focus patch setup runs only once
ia319 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change looks good to me! What do you think of scoping the declarations to the if statement so that there's no chance for the Set to be reinstantiated?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct, and
patchedFocus = truealso needs to be placed outside, because theSetmight not be invoked.