Skip to content

Conversation

@JReinhold
Copy link
Contributor

@JReinhold JReinhold commented Oct 2, 2025

This is a retry of #32586 that failed due to a bad publishing workflow

This is an automated pull request that bumps the version from 10.0.0-beta.8 to 10.0.0-beta.9.
Once this pull request is merged, it will trigger a new release of version 10.0.0-beta.9.
If you're not a core maintainer with permissions to release you can ignore this pull request.

To do

Before merging the PR, there are a few QA steps to go through:

  • Add the "freeze" label to this PR, to ensure it doesn't get automatically forced pushed by new changes.
  • Add the "ci:daily" label to this PR, to trigger the full test suite to run on this PR.

And for each change below:

  1. Ensure the change is appropriate for the version bump. E.g. patch release should only contain patches, not new or de-stabilizing features. If a change is not appropriate, revert the PR.
  2. Ensure the PR is labeled correctly with one of: "BREAKING CHANGE", "feature request", "bug", "maintenance", "dependencies", "documentation", "build", "unknown".
  3. Ensure the PR title is correct, and follows the format "[Area]: [Summary]", e.g. "React: Fix hooks in CSF3 render functions". If it is not correct, change the title in the PR.
    • Areas include: React, Vue, Core, Docs, Controls, etc.
    • First word of summary indicates the type: “Add”, “Fix”, “Upgrade”, etc.
    • The entire title should fit on a line

This is a list of all the PRs merged and commits pushed directly to next, that will be part of this release:

  • 🔧 Maintenance: Svelte: Simplify public types - use modern Component #31394
  • 🔧 Maintenance: Telemetry: Log userAgent in onboarding #32566 (will also be patched)
  • 🔧 Maintenance: Automigrations: Add automigration for viewport and backgrounds #31614 (will also be patched)
  • 🏗️ Build: Release tooling: Use npm Trusted Publishing #32607

If you've made any changes doing the above QA (change PR titles, revert PRs), manually trigger a re-generation of this PR with this workflow and wait for it to finish. It will wipe your progress in this to do, which is expected.

Feel free to manually commit any changes necessary to this branch after you've done the last re-generation, following the Make Manual Changes section in the docs, especially if you're making changes to the changelog.

When everything above is done:


Generated changelog

10.0.0-beta.9

  • Automigrations: Add automigration for viewport and backgrounds - #31614, thanks valentinpalkovic!
  • Svelte: Simplify public types - use modern Component - #31394, thanks xeho91!
  • Telemetry: Log userAgent in onboarding - #32566, thanks shilman!

Summary by CodeRabbit

  • New Features

    • Added automigration to move viewport and backgrounds settings to the globals API.
    • Onboarding telemetry now includes the userAgent for improved insights.
  • Refactor

    • Simplified Svelte renderer public types to use the modern Component API, improving Meta/StoryObj typings and developer ergonomics.
  • Documentation

    • Updated changelogs (9.1.9–9.1.10, 10.0.0-beta.9) and next-version notes to reflect new migrations, Svelte type updates, and telemetry changes.
  • Chores

    • Upgraded Yarn to 4.10.3 across the repository.

valentinpalkovic and others added 30 commits April 25, 2025 13:39
…Component.svelte

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
@JReinhold JReinhold self-assigned this Oct 2, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 2, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

The PR adds an automigration for moving Storybook viewport/backgrounds parameters to the globals API, including a new fix (addon-globals-api), AST utilities, and comprehensive tests. It registers the fix in the automigration index. Svelte renderer public types are refactored to use Svelte’s modern Component types, with corresponding test and typings updates. Onboarding telemetry now logs navigator.userAgent. CI workflow tweaks include permission updates and removing a YARN_NPM_AUTH_TOKEN. Yarn is bumped to 4.10.3 across the repo. Changelogs and docs are updated to reflect 10.0.0-beta.9 content.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor Dev as Developer
  participant CLI as CLI Automigrate
  participant Fix as addon-globals-api Fix
  participant FS as File System

  Dev->>CLI: run automigrate
  CLI->>Fix: check(project config)
  alt needs migration
    Fix-->>CLI: options (viewport/backgrounds)
    CLI->>Dev: prompt to apply
    Dev-->>CLI: confirm
    CLI->>Fix: run(options, dryRun?)
    Fix->>FS: load preview config
    Fix->>Fix: migrate config (options -> options/initialGlobals)
    Fix->>FS: write preview config (unless dryRun)
    Fix->>FS: find story files
    loop stories (p-limit)
      Fix->>FS: read story file
      Fix->>Fix: transformStoryFile (parameters -> globals)
      alt changed
        Fix->>FS: write story file (unless dryRun)
      else no change
        Fix-->>Fix: skip write
      end
    end
    Fix-->>CLI: result (errors per file if any)
  else no migration
    Fix-->>CLI: null
  end
Loading
sequenceDiagram
  autonumber
  participant UI as Onboarding.tsx
  participant Nav as globalThis.navigator
  participant Chan as STORYBOOK_ADDON_ONBOARDING_CHANNEL

  UI->>Nav: read userAgent
  UI->>Chan: emit telemetry { userAgent, ... }
  UI->>Chan: emit survey { userAgent, ... }
Loading

Possibly related issues

Possibly related PRs

Suggested labels

maintenance, build, automigrations, ci:normal

Suggested reviewers

  • kylegach
  • jonniebigodes
✨ Finishing touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch version-non-patch-from-10.0.0-beta.8

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a3a4242 and 7389c93.

⛔ Files ignored due to path filters (3)
  • .yarn/releases/yarn-4.10.3.cjs is excluded by !**/.yarn/**
  • .yarn/releases/yarn-4.9.1.cjs is excluded by !**/.yarn/**
  • code/yarn.lock is excluded by !**/yarn.lock, !**/*.lock
📒 Files selected for processing (39)
  • .github/workflows/publish.yml (3 hunks)
  • .yarnrc.yml (1 hunks)
  • CHANGELOG.md (1 hunks)
  • CHANGELOG.prerelease.md (1 hunks)
  • code/.yarnrc.yml (1 hunks)
  • code/addons/onboarding/src/Onboarding.tsx (3 hunks)
  • code/lib/cli-storybook/src/automigrate/fixes/addon-globals-api.test.ts (1 hunks)
  • code/lib/cli-storybook/src/automigrate/fixes/addon-globals-api.ts (1 hunks)
  • code/lib/cli-storybook/src/automigrate/fixes/index.ts (2 hunks)
  • code/lib/cli-storybook/src/automigrate/helpers/addon-a11y-parameters.ts (4 hunks)
  • code/lib/cli-storybook/src/automigrate/helpers/ast-utils.ts (1 hunks)
  • code/package.json (2 hunks)
  • code/renderers/svelte/package.json (0 hunks)
  • code/renderers/svelte/src/__test__/Button.svelte (1 hunks)
  • code/renderers/svelte/src/__test__/ButtonV5.svelte (0 hunks)
  • code/renderers/svelte/src/__test__/Decorator.svelte (1 hunks)
  • code/renderers/svelte/src/__test__/Decorator2.svelte (1 hunks)
  • code/renderers/svelte/src/__test__/composeStories/Button.stories.ts (1 hunks)
  • code/renderers/svelte/src/__test__/composeStories/CustomRenderComponent.svelte (1 hunks)
  • code/renderers/svelte/src/__test__/composeStories/LoaderStoryComponent.svelte (1 hunks)
  • code/renderers/svelte/src/__test__/composeStories/StoryWithLocaleComponent.svelte (1 hunks)
  • code/renderers/svelte/src/__test__/composeStories/portable-stories.test.ts (1 hunks)
  • code/renderers/svelte/src/public-types.test.ts (9 hunks)
  • code/renderers/svelte/src/public-types.ts (3 hunks)
  • code/renderers/svelte/src/types.ts (1 hunks)
  • code/renderers/svelte/src/typings.d.ts (1 hunks)
  • docs/versions/next.json (1 hunks)
  • package.json (1 hunks)
  • scripts/.yarnrc.yml (1 hunks)
  • scripts/package.json (1 hunks)
  • test-storybooks/ember-cli/.yarnrc.yml (1 hunks)
  • test-storybooks/external-docs/.yarnrc.yml (1 hunks)
  • test-storybooks/portable-stories-kitchen-sink/nextjs/.yarnrc.yml (1 hunks)
  • test-storybooks/portable-stories-kitchen-sink/react/.yarnrc.yml (1 hunks)
  • test-storybooks/portable-stories-kitchen-sink/svelte/.yarnrc.yml (1 hunks)
  • test-storybooks/portable-stories-kitchen-sink/vue3/.yarnrc.yml (1 hunks)
  • test-storybooks/server-kitchen-sink/.yarnrc.yml (1 hunks)
  • test-storybooks/standalone-preview/.yarnrc.yml (1 hunks)
  • test-storybooks/yarn-pnp/.yarnrc.yml (1 hunks)

Comment @coderabbitai help to get the list of available commands and usage tips.

@JReinhold JReinhold added the freeze Freeze the Release PR with this label label Oct 2, 2025
@JReinhold JReinhold merged commit 6062ab5 into next-release Oct 2, 2025
10 of 15 checks passed
@JReinhold JReinhold deleted the version-non-patch-from-10.0.0-beta.8 branch October 2, 2025 11:56
@nx-cloud
Copy link

nx-cloud bot commented Oct 2, 2025

View your CI Pipeline Execution ↗ for commit 7389c93

Command Status Duration Result
nx run-many -t build --parallel=3 ✅ Succeeded 56s View ↗

☁️ Nx Cloud last updated this comment at 2025-10-02 12:19:25 UTC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

freeze Freeze the Release PR with this label

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants