-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
Release: Prerelease 10.0.0-beta.9 (retry2) #32613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…actor-svelte-renderer-types
…actor-svelte-renderer-types
…com/xeho91/storybook into feat/refactor-svelte-renderer-types
…Component.svelte Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
…com/xeho91/storybook into feat/refactor-svelte-renderer-types
…s-backgrounds-automigrations
…tion logic with storiesPaths parameter
…ns special characters in value name
… improve formatting for better readability
…kgrounds-automigrations Automigrations: Add automigration for viewport and backgrounds
Telemetry: Log userAgent in onboarding
…ypes Svelte: Simplify public types - use modern `Component`
Release tooling: Use npm Trusted Publishing
|
Caution Review failedThe pull request is closed. WalkthroughThe PR adds an automigration for moving Storybook viewport/backgrounds parameters to the globals API, including a new fix (addon-globals-api), AST utilities, and comprehensive tests. It registers the fix in the automigration index. Svelte renderer public types are refactored to use Svelte’s modern Component types, with corresponding test and typings updates. Onboarding telemetry now logs navigator.userAgent. CI workflow tweaks include permission updates and removing a YARN_NPM_AUTH_TOKEN. Yarn is bumped to 4.10.3 across the repo. Changelogs and docs are updated to reflect 10.0.0-beta.9 content. Sequence Diagram(s)sequenceDiagram
autonumber
actor Dev as Developer
participant CLI as CLI Automigrate
participant Fix as addon-globals-api Fix
participant FS as File System
Dev->>CLI: run automigrate
CLI->>Fix: check(project config)
alt needs migration
Fix-->>CLI: options (viewport/backgrounds)
CLI->>Dev: prompt to apply
Dev-->>CLI: confirm
CLI->>Fix: run(options, dryRun?)
Fix->>FS: load preview config
Fix->>Fix: migrate config (options -> options/initialGlobals)
Fix->>FS: write preview config (unless dryRun)
Fix->>FS: find story files
loop stories (p-limit)
Fix->>FS: read story file
Fix->>Fix: transformStoryFile (parameters -> globals)
alt changed
Fix->>FS: write story file (unless dryRun)
else no change
Fix-->>Fix: skip write
end
end
Fix-->>CLI: result (errors per file if any)
else no migration
Fix-->>CLI: null
end
sequenceDiagram
autonumber
participant UI as Onboarding.tsx
participant Nav as globalThis.navigator
participant Chan as STORYBOOK_ADDON_ONBOARDING_CHANNEL
UI->>Nav: read userAgent
UI->>Chan: emit telemetry { userAgent, ... }
UI->>Chan: emit survey { userAgent, ... }
Possibly related issues
Possibly related PRs
Suggested labels
Suggested reviewers
✨ Finishing touches
🧪 Generate unit tests
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro ⛔ Files ignored due to path filters (3)
📒 Files selected for processing (39)
Comment |
|
View your CI Pipeline Execution ↗ for commit 7389c93
☁️ Nx Cloud last updated this comment at |
This is a retry of #32586 that failed due to a bad publishing workflow
This is an automated pull request that bumps the version from
10.0.0-beta.8to10.0.0-beta.9.Once this pull request is merged, it will trigger a new release of version
10.0.0-beta.9.If you're not a core maintainer with permissions to release you can ignore this pull request.
To do
Before merging the PR, there are a few QA steps to go through:
And for each change below:
This is a list of all the PRs merged and commits pushed directly to
next, that will be part of this release:Component#31394If you've made any changes doing the above QA (change PR titles, revert PRs), manually trigger a re-generation of this PR with this workflow and wait for it to finish. It will wipe your progress in this to do, which is expected.
Feel free to manually commit any changes necessary to this branch after you've done the last re-generation, following the Make Manual Changes section in the docs, especially if you're making changes to the changelog.
When everything above is done:
Generated changelog
10.0.0-beta.9
Component- #31394, thanks xeho91!Summary by CodeRabbit
New Features
Refactor
Documentation
Chores