Skip to content

Conversation

@beeequeue
Copy link
Contributor

@beeequeue beeequeue commented Sep 22, 2025

What I did

This PR updates eslint-plugin-depend to the latest version, updating the list of recommended/not recommended dependencies and removes the last usage of fd-package-json. 😄

When I ran linting locally no new warnings or errors showed up.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

It should just change the linting outcomes.

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

You can run the lint commands locally if you want.

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

Summary by CodeRabbit

  • Chores
    • Updated the eslint-plugin-depend development dependency to version 1.3.1 across project packages.
    • Aligns linting tooling with newer rule compatibility and improvements.
    • No changes to application features or behavior; build and runtime remain unaffected.
    • Developers may notice updated linting feedback during local development and CI.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 22, 2025

Walkthrough

Updated eslint-plugin-depend version from ^0.11.0 to ^1.3.1 in two package.json files under code/ and scripts/. No other fields or files changed.

Changes

Cohort / File(s) Summary
Lint plugin bump
code/package.json, scripts/package.json
Bumped dependency eslint-plugin-depend from ^0.11.0 to ^1.3.1.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

I nudge my whiskers at version one-three-one,
Linting carrots aligned, the chores are done.
Two gardens tended—scripts and code—
Fewer weeds upon the road.
Thump, thump—dependencies pruned, I run! 🥕🐇

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
Title Check ✅ Passed The title clearly indicates the primary change (updating an ESLint-related dependency) and is concise, so it relates to the changeset; however it uses a slightly different package name ("eslint-depend-plugin") than the actual dependency updated in the PR ("eslint-plugin-depend"), which is a minor naming inconsistency but does not make the title misleading.
✨ Finishing touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

  • Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
  • Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.


Comment @coderabbitai help to get the list of available commands and usage tips.

@nx-cloud
Copy link

nx-cloud bot commented Sep 22, 2025

View your CI Pipeline Execution ↗ for commit 3b7f654

Command Status Duration Result
nx run-many -t build --parallel=3 ✅ Succeeded 51s View ↗

☁️ Nx Cloud last updated this comment at 2025-09-23 10:22:47 UTC

Copy link

@vmaineng vmaineng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work on bumping the dependency and cleaning up fd-package-json 🎉
Thanks for confirming the lint passes locally, with CI coverage too, I agree no manual testing is needed here. This looks good to merge!

@ndelangen ndelangen self-assigned this Sep 23, 2025
@ndelangen ndelangen added build Internal-facing build tooling & test updates ci:normal labels Sep 23, 2025
@ndelangen ndelangen changed the title Update eslint-depend-plugin Dependency: Update eslint-depend-plugin Sep 23, 2025
@storybook-app-bot
Copy link

Package Benchmarks

Commit: 3b7f654, ran on 23 September 2025 at 10:11:55 UTC

The following packages have significant changes to their size or dependencies:

@storybook/nextjs

Before After Difference
Dependency count 528 531 🚨 +3 🚨
Self size 939 KB 939 KB 🎉 -184 B 🎉
Dependency size 58.24 MB 58.40 MB 🚨 +161 KB 🚨
Bundle Size Analyzer Link Link

@ndelangen ndelangen merged commit 0ef2a79 into storybookjs:next Sep 23, 2025
53 checks passed
@github-actions github-actions bot mentioned this pull request Sep 23, 2025
18 tasks
@beeequeue beeequeue deleted the depend-plugin branch September 23, 2025 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Internal-facing build tooling & test updates ci:normal

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants