Skip to content

Conversation

@ndelangen
Copy link
Member

@ndelangen ndelangen commented Aug 20, 2025

What I did

VTA did not allow for sb10-beta version range, I broadened this version range.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

Greptile Summary

This PR updates the @chromatic-com/storybook package from version ^4 to ^4.1.1 across two package.json files in the Storybook codebase. The change is made to the main workspace package.json and the yarn-pnp test storybook configuration. This update addresses a compatibility issue where the Visual Tests Addon (VTA) did not support the Storybook 10 beta version range.

The @chromatic-com/storybook package provides Chromatic's Visual Tests addon, which integrates visual regression testing capabilities directly into Storybook. By updating to version 4.1.1, the addon now supports a broader version range that includes compatibility with Storybook 10 beta releases. This is a preparatory change for Storybook's upcoming major version release, ensuring that visual testing functionality continues to work seamlessly as Storybook evolves.

The change maintains consistency across the codebase by updating both the main workspace dependency and the test environment dependency, following Storybook's pattern of keeping dependencies synchronized across different configurations.

Confidence score: 5/5

  • This PR is safe to merge with minimal risk
  • Score reflects a straightforward dependency version update with clear compatibility benefits
  • No files require special attention

@ndelangen ndelangen self-assigned this Aug 20, 2025
@ndelangen ndelangen changed the title Update @chromatic-com/storybook dependency to version 4.1.1 in package.json and yarn.lock Update: @chromatic-com/storybook Aug 20, 2025
@ndelangen ndelangen marked this pull request as ready for review August 20, 2025 12:14
@dosubot
Copy link

dosubot bot commented Aug 20, 2025

Related Documentation

No published documentation to review for changes on this repository.
Write your first living document

How did I do? Any feedback?  Join Discord

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 files reviewed, no comments

Edit Code Review Bot Settings | Greptile

@nx-cloud
Copy link

nx-cloud bot commented Aug 20, 2025

View your CI Pipeline Execution ↗ for commit 032c477

Command Status Duration Result
nx run-many -t build --parallel=3 ✅ Succeeded 50s View ↗

☁️ Nx Cloud last updated this comment at 2025-08-20 13:17:09 UTC

@ndelangen ndelangen changed the title Update: @chromatic-com/storybook Update: Addon @chromatic-com/storybook Aug 20, 2025
@ndelangen ndelangen changed the title Update: Addon @chromatic-com/storybook Update: Satellite repos after major version bump Aug 20, 2025
@ndelangen ndelangen merged commit b28b1a8 into next Aug 20, 2025
27 of 34 checks passed
@ndelangen ndelangen deleted the norbert/vta-upgrade-10 branch August 20, 2025 13:17
@github-actions github-actions bot mentioned this pull request Aug 20, 2025
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants