Skip to content

Core: Don't update interactions panel state until we reach the rendering phase #32163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 31, 2025
Merged

Core: Don't update interactions panel state until we reach the rendering phase #32163

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion code/core/src/component-testing/components/Panel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,12 +253,18 @@ export const Panel = memo<{ refId?: string; storyId: string; storyUrl: string }>
);
},
[STORY_RENDER_PHASE_CHANGED]: (event) => {
if (event.newPhase === 'preparing' || event.newPhase === 'loading') {
// A render cycle may not actually make it to the rendering phase.
// We don't want to update any state until it does.
return;
}

lastRenderId.current = Math.max(lastRenderId.current, event.renderId || 0);
if (lastRenderId.current !== event.renderId) {
return;
}

if (event.newPhase === 'preparing') {
if (event.newPhase === 'rendering') {
log.current = [getInternalRenderLogItem(CallStates.ACTIVE)];
calls.current.set(INTERNAL_RENDER_CALL_ID, getInternalRenderCall(storyId));
set({
Expand Down
Loading