Skip to content

Conversation

@ghengeveld
Copy link
Member

Issue: -

What I did

This deprecates showRoots in favor of sidebar.showRoots, moves the recently introduced collapsedRoots (beta) to be under sidebar as well and removes sidebarAnimations altogether.

Should we show a deprecation warning for sidebarAnimations as well? It's not going to break, but people may want to clean up their config.

How to test

  • Is this testable with Jest or Chromatic screenshots? Yes, nothing should change
  • Does this need a new example in the kitchen sink apps? No
  • Does this need an update to the documentation? Yes, it's there

If your answer is yes to any of these, please make sure to include it in your PR.

@github-actions
Copy link
Contributor

Fails
🚫

Please choose only one of these labels: ["documentation","maintenance"]

Generated by 🚫 dangerJS against c263d1d

@shilman shilman changed the title [core] Namespace sidebar config options Core: Namespace sidebar config options Feb 26, 2021
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great @ghengeveld -- thanks for cleaning up 🙏

This was referenced Mar 14, 2021
@nhoizey
Copy link

nhoizey commented Apr 27, 2021

I lost a few minutes trying to find the documentation for sidebarAnimations I had in a project, so I would vote for a deprecation warning and at leat a mention in MIGRATION.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

configuration maintenance User-facing maintenance tasks ui

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants