Skip to content

Conversation

@ghengeveld
Copy link
Member

@ghengeveld ghengeveld commented Feb 26, 2021

Issues: #13943 #13877 #13463

What I did

This enables searching for story names. When both a story and component are found and they're parent/child, only the first one is displayed (whichever ranks higher), to avoid multiple results that lead to the same place.

Additionally, this fixes the event listener for /. Turns out we had two competing listeners. I removed the custom one and fixed the core one to also select the input text.

How to test

  • Is this testable with Jest or Chromatic screenshots? no
  • Does this need a new example in the kitchen sink apps? no
  • Does this need an update to the documentation? no

If your answer is yes to any of these, please make sure to include it in your PR.

@shilman shilman changed the title [core] Enable search for stories and fix / event listener UI: Enable search for stories and fix / event listener Feb 26, 2021
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 😍

This was referenced Mar 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants