Skip to content

Conversation

@gaetanmaisse
Copy link
Member

@gaetanmaisse gaetanmaisse commented Feb 1, 2021

What I did

Do not recompile packages before publishing with the run-registry script. It will:

  • 🚓 ensure that the outputs of the build step are really used
  • 🚀 speed up the publish step on CI a lot a bit

How to test

  • CI should still be 🟢 and the duration of the publish step should decrease a lot a bit

…` script

It will:
 - ensure that the outputs of the build step are really used
 - speed up the publish step on CI a lot
@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2021

Fails
🚫

PR is not labeled with one of: ["cleanup","BREAKING CHANGE","feature request","bug","documentation","maintenance","dependencies","other"]

Generated by 🚫 dangerJS against f1f8269

@gaetanmaisse gaetanmaisse added the maintenance User-facing maintenance tasks label Feb 1, 2021
@gaetanmaisse gaetanmaisse marked this pull request as ready for review February 1, 2021 20:28
Copy link
Contributor

@phated phated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We chatted about this and the reasoning makes sense! Do we need to label this with e2e-extended?

Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shilman shilman added the run e2e extended test suite Run the e2e extended test suite in CircleCI workflows label Feb 2, 2021
@shilman shilman merged commit 0c9aebf into next Feb 2, 2021
@shilman shilman deleted the tech/improve-publish-step-on-ci branch February 2, 2021 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance User-facing maintenance tasks run e2e extended test suite Run the e2e extended test suite in CircleCI workflows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants