CLI: Handle package versions in package strings for generators

[phated]

Issue: N/A

What I did

Sometimes packages needed by generators might not be published on the latest tag, so the wrong version would be added to the package.json when using a generator.

An example of this is vue-loader, which publishes v16 (with Vue 3 support) on the next tag. Upon adding vue-loader to a generator, it would add v15 to the package.json.

This adds support for generators to request versions in the string, like so:

baseGenerator(packageManager, npmOptions, options, 'vue3', {
    extraPackages: ['vue-loader@^16.0.0'],
});

How to test

• Is this testable with Jest or Chromatic screenshots? The e2e tests will catch this once leveraged by a generator
• Does this need a new example in the kitchen sink apps? ❌
• Does this need an update to the documentation? ❌

If your answer is yes to any of these, please make sure to include it in your PR.

[shilman]

LGTM except for a corner case

[shilman]

AFAICT this will fail when packageVersion is a literal version. getVersion calls satisfies and if it fails it uses the latest version. Consider the case where latest is 1.3.5 and we need version 1.2.0.

[phated]

I think this only fails if the version doesn't exist. I tested semver.satisfies('1.0.0', '1.0.0') and it returns true so as long as the literal version exists inside versions.reverse(), it should find one.

That being said, the latestVersion method could probably be hardened against a constraint not being satisfied by all versions on npm. Do you want me to do that as part of this PR?

[phated]

(current is only ever set for @storybook packages, so the versionToUse ternary only ever gets applied to those)

[shilman]

Aha my bad

[shilman]

💯