Svelte: Fixes component name in docgen-loader #13760
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j3rem1e
added
bug
patch:yes
phated
suggested changes
Feb 1, 2021
Contributor
phated
left a comment
phated
left a comment
There was a problem hiding this comment.
Looking good. Just a few things.
Contributor
Author
|
@phated I have updated my PR with your remarks, thanks ! |
shilman
added
the
patch:done
shilman
added a commit
that referenced
this pull request
Feb 2, 2021
Svelte: Fixes component name in docgen-loader
This was referenced Mar 8, 2021
Closed
This was referenced Mar 8, 2021
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #13742
What I did
The Svelte component name was not correctly guessed for unusual files names.
I use now the function from svelte/compiler which generates the component name.
However, this function is not exported by Svelte, so I had to duplicate it in the loader.
How to test