Skip to content

Conversation

@phated
Copy link
Contributor

@phated phated commented Jan 27, 2021

Issue: N/A

What I did

I'm noticing a bunch of failures on the "Unit Tests" GH Action. I believe this is because the cache action is fetching stale caches. I removed the "restore-keys" option so it only ever pulls a cache that matches the yarn.lock file.

How to test

  • Is this testable with Jest or Chromatic screenshots? ❌
  • Does this need a new example in the kitchen sink apps? ❌
  • Does this need an update to the documentation? ❌

If your answer is yes to any of these, please make sure to include it in your PR.

@phated phated added the maintenance User-facing maintenance tasks label Jan 27, 2021
@phated phated requested review from ndelangen and shilman January 27, 2021 23:28
@phated phated requested a review from danielduan as a code owner January 27, 2021 23:28
@gaetanmaisse
Copy link
Member

I would go one step further and completely remove the unit tests workflow from the GitHub Actions.
I guess it was added to give it a try with GH Actions but, at the moment, I don't see any benefit to keep it as it is a pure duplicate of what we have on CircleCI, it takes so much time to run and is often failing. What's your opinion on that @ndelangen ?

@phated
Copy link
Contributor Author

phated commented Feb 1, 2021

@gaetanmaisse Can we merge this and make that decision later? It is causing people's PRs to be stalled.

@gaetanmaisse gaetanmaisse merged commit f1c093a into storybookjs:next Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance User-facing maintenance tasks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants