UI: Fix shortcut button focus border to support high contrast #13699
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
micahgodbolt
requested review from
igor-dv,
ndelangen and
tmeasday
as code owners
Member
|
Thanks @micahgodbolt! @tooppaaa @domyen @jsomsanith can I get a review? |
Member
|
Hi @adagar any chance I can get a review for this? |
Contributor
|
@shilman sure, I can take a look at this sometime today! |
domyen
requested changes
Feb 22, 2021
Member
domyen
left a comment
domyen
left a comment
There was a problem hiding this comment.
Thanks @micahgodbolt! Looks good, suggestions below.
Co-authored-by: Dominic Nguyen <[email protected]>
adagar
reviewed
Feb 22, 2021
Contributor
|
Had an error preventing builds from working locally, but not sure if I'm doing something wrong. Additionally: How do you activate the high-contrast setting you show in the screenshot above? Is it the windows built-in approach? |
shilman
approved these changes
Feb 25, 2021
Member
shilman
left a comment
shilman
left a comment
There was a problem hiding this comment.
LGTM! Thanks @micahgodbolt @adagar @domyen !!!
shilman
changed the title
This was referenced Mar 7, 2021
This was referenced Mar 12, 2021
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #13373
box shadows are not an accessible way to add focus to a button because shadows are dropped by high contrast mode. Using a pseudo element with border avoids the issue of borders messing with box sizing.