Build: Ensure consistency of Chromatic snapshots of Zoom stories #13676
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tency The zoom related stories look to take some time to be properly rendered and so the Chromatic snapshots aren't always the same. I added a small delay before the snapshot to ensure the rendering/zoom is done. Signed-off-by: Gaëtan Maisse <[email protected]>
shilman
approved these changes
Jan 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: The zoom related stories look to take some time to be properly rendered, so the Chromatic snapshots aren't always the same causing some false positive changes in almost every PR.
What I did
I followed Chromatic doc and added a small delay to ensure the rendering/zoom is done before taking the snapshot.
Details: https://www.chromatic.com/docs/delay
How to test