Skip to content

Conversation

@j3rem1e
Copy link
Contributor

@j3rem1e j3rem1e commented Jan 16, 2021

Issue: None

What I did

Improvements on the generated ArgsTable with Svelte, like Vue : 3 sections, Properties, Events and Slots.

How to test

  • Is this testable with Jest or Chromatic screenshots? Done
  • Does this need a new example in the kitchen sink apps? Done
  • Does this need an update to the documentation? No

@j3rem1e j3rem1e force-pushed the svelte-argstable branch 2 times, most recently from b94ffd2 to 8d434fc Compare January 20, 2021 11:11
@shilman shilman changed the title Svelte: Adding Slots and Events in the generated ArgsTable Svelte: Add Slots and Events to the generated ArgsTable Jan 20, 2021
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @j3rem1e !

One request: you're including test cases for slots and events in the extraction unit test, but can you also include an example in the Args Table story for svelte-kitchen-sink? Thanks! 🙏

@j3rem1e
Copy link
Contributor Author

j3rem1e commented Jan 20, 2021

I have added examples for slots and events in the argstable story.
I have attached the related code to this story to show how to document theses properties.

As discussed on Discord, you can see that this source is not fully highlighted, because the language is jsx and not svelte.

@j3rem1e j3rem1e requested a review from shilman January 20, 2021 18:51
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great! 💯

@shilman shilman merged commit ba4be81 into storybookjs:next Jan 22, 2021
@j3rem1e j3rem1e deleted the svelte-argstable branch January 22, 2021 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants