Skip to content

Build: strengthen conditions under which Webpack stats are written in file #13231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Build: strengthen conditions under which Webpack stats are written in file #13231

wants to merge 2 commits into from

Conversation

@gaetanmaisse
Copy link
Member

@gaetanmaisse gaetanmaisse commented Nov 23, 2020 •
edited
Loading

Issue: CLI Tests CI job is failing for a few days/weeks because in some cases we are trying to output some undefined Webpack stats in a file, inside a potentially non-existing directory.

What I did

  • Ensure the directory used to output Webpack stats exists before writing files in it.
  • Strengthen the types and checks before trying to write anything in files.

How to test

  • CLI Tests CI job should be back to 🟢

@gaetanmaisse gaetanmaisse added maintenance User-facing maintenance tasks core labels Nov 23, 2020
@gaetanmaisse
Copy link
Member Author

gaetanmaisse commented Nov 23, 2020

@tooppaaa do you know why we have a staticDir: 'dist' here? We have the same for ember and a dynamic value for react script but nothing for all the other frameworks, do you think it's normal?

The CLI tests are failing for that now.

@gaetanmaisse gaetanmaisse mentioned this pull request Nov 23, 2020
Merged
@tooppaaa
Copy link
Contributor

tooppaaa commented Nov 24, 2020

Unfortunately no, I don't know. I added this option for some framework. In the diff you shared, it must have been a bad copy paste. I don't see any good reason

@gaetanmaisse gaetanmaisse mentioned this pull request Nov 24, 2020
Merged
@gaetanmaisse gaetanmaisse marked this pull request as ready for review November 25, 2020 08:27
@gaetanmaisse
Copy link
Member Author

gaetanmaisse commented Nov 25, 2020

Closing in favor of #13266

@gaetanmaisse gaetanmaisse deleted the fix-cli-tests branch November 25, 2020 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alterx alterx Awaiting requested review from alterx

@igor-dv igor-dv Awaiting requested review from igor-dv

@tmeasday tmeasday Awaiting requested review from tmeasday

@ghengeveld ghengeveld Awaiting requested review from ghengeveld

Assignees

No one assigned

Labels

core maintenance User-facing maintenance tasks

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gaetanmaisse @tooppaaa