[Bug]: Stories glob should exclude node_modules

[shilman]

Describe the bug

Encountered the following bug upgrading HeroUI from SB8 to SB9.

The following line:

https://github.com/shilman/heroui/blob/328c57d8ea4d27306a7001bb702a1c018953ed0c/packages/storybook/.storybook/main.ts#L8

Had to be modified to:

https://github.com/shilman/heroui/blob/07928b4669e39b270d4a694684aee7c3b5f5e52b/packages/storybook/.storybook/main.ts#L8

Because SB9 was picking up stories from node_modules. This is a common pattern and an unintentional breaking change in SB9.

Reproduction link

https://github.com/shilman/heroui/

Reproduction steps

First:

pnpm install
pnpm run sb

Then revert the change to main.ts and

pnpm run sb

System

Storybook Environment Info:

  System:
    OS: macOS 15.7.1
    CPU: (10) arm64 Apple M1 Pro
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 22.20.0 - /usr/local/bin/node
    npm: 10.9.3 - /usr/local/bin/npm
    pnpm: 10.6.2 - ~/Library/pnpm/.tools/pnpm/10.6.2/bin/pnpm <----- active
  Browsers:
    Chrome: 141.0.7390.123
    Safari: 26.0.1
  npmPackages:
    @storybook/addon-a11y: ^9.1.15 => 9.1.15 
    @storybook/addon-docs: ^9.1.15 => 9.1.15 
    @storybook/addon-links: ^9.1.15 => 9.1.15 
    @storybook/cli: ^9.1.15 => 9.1.15 
    @storybook/react-vite: ^9.1.15 => 9.1.15 
    storybook: ^9.1.15 => 9.1.15

Additional context

No response

[dosubot]

This is a known issue in Storybook 9, especially in monorepo setups with pnpm, where the story glob pattern can unintentionally match files inside node_modules. This did not happen in Storybook 8 and is considered a breaking change by several users and maintainers. The recommended workaround is to explicitly exclude node_modules in your stories glob pattern, for example:

stories: ['../packages/*/!(node_modules)/**/*.@(mdx|stories.@(js|jsx|ts|tsx))']

or to target only your local story files. This approach prevents Storybook from loading stories from node_modules and avoids duplicate or unintended story inclusion. You can see more details and community discussion in this issue and this discussion.

To reply, just mention @dosu.

---

^{How did I do? Good | Irrelevant | Incorrect | Verbose | Hallucination | Report 🐛 | Other}    

[ia319]

The cwd is set to Storybook's own package directory (code/core/src/core-server/utils/getStoryIndexGenerator.ts#L15) (for example, /heroui/packages/storybook).

globby interprets the ignore rules based on its current cwd (code/core/src/core-server/utils/StoryIndexGenerator.ts#L168).

Therefore, the rule:

ignore: ['**/node_modules/**']

(code/core/src/common/utils/common-glob-options.ts) only actually applies to the node_modules directory inside packages/storybook.

When trying to navigate upward (../) to the monorepo root and then downward into other component packages (components) to find files like:

../../components/**/stories/**/*.stories.@(js|jsx|ts|tsx)

globby still uses packages/storybook as the cwd.

In this case, the node_modules directories inside packages/components appear to packages/storybook as ../components/.../node_modules.

This path cannot be matched by the **/node_modules/** ignore rule, which is relative to packages/storybook.

[ia319]

设置cwd为 Storybook 自己的包目录（code/core/src/core-server/utils/getStoryIndexGenerator.ts#L15）（例如/heroui/packages/storybook）。

globby``ignore根据其当前的cwd（ ）解释规则code/core/src/core-server/utils/StoryIndexGenerator.ts#L168。

因此，规则：

ignore: ['/node_modules/']
( code/core/src/common/utils/common-glob-options.ts) 实际上仅适用于node_modules里面的目录packages/storybook。

当尝试向上导航（../）到 monorepo 根目录，然后向下导航到其他组件包（components）以查找如下文件时：

../../components/**/stories/**/*.stories.@(js|jsx|ts|tsx)

globby仍packages/storybook用作cwd。

在这种情况下，node_modules里面的目录packages/components显示packages/storybook为../components/.../node_modules。

该路径无法被忽略规则匹配**/node_modules/**，该规则与 相对packages/storybook。

I added story files under both /heroui/packages/storybook and /heroui/packages/storybook/node_modules, and as I suspected above, the files in node_modules were indeed excluded.

Since rebuilding and packing are required for changes, there might be caching issues, so I’m not entirely sure if it works exactly the way I think.