Added Link mark supporting email, anchors and custom attributes #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Copilot <[email protected]>
….php in line with other files
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #32 +/- ##
============================================
+ Coverage 62.83% 67.64% +4.81%
- Complexity 18 28 +10
============================================
Files 5 6 +1
Lines 113 136 +23
============================================
+ Hits 71 92 +21
- Misses 42 44 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
edodusi
requested changes
Nov 3, 2025
src/Mark/Link.php
Outdated
| { | ||
| return [ | ||
| 'HTMLAttributes' => [ | ||
| 'target' => '_blank', |
Contributor
There was a problem hiding this comment.
not sure this should be the default, why do you think it should?
Contributor
Author
There was a problem hiding this comment.
@edodusi I agree, this was taken from the base Link class in TipTap, I wanted to minimise what changes my replacement makes but as Storyblok includes a target in the JSON we don’t need this. I’ll update the PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The standard TipTap Link mark didn’t support all the features of Storyblok’s links. This new Link mark implements email links, anchors and custom attributes