Skip to content

Conversation

@maoberlehner
Copy link
Contributor

Fixes WDX-188

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances type safety in the js-client package by adding explicit type annotations to previously untyped variables, addressing WDX-188.

Key Changes:

  • Added explicit type annotations to array and nullable variables
  • Improved type safety for timeout handling with additional null check

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
packages/js-client/src/utils.ts Added string array type annotation to pairs variable
packages/js-client/src/sbFetch.ts Added type annotations for body and timeout variables, plus null safety check for timeout

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Oct 24, 2025

Open in StackBlitz

@storyblok/astro

npm i https://pkg.pr.new/@storyblok/astro@362

storyblok

npm i https://pkg.pr.new/storyblok@362

@storyblok/eslint-config

npm i https://pkg.pr.new/@storyblok/eslint-config@362

@storyblok/js

npm i https://pkg.pr.new/@storyblok/js@362

storyblok-js-client

npm i https://pkg.pr.new/storyblok-js-client@362

@storyblok/management-api-client

npm i https://pkg.pr.new/@storyblok/management-api-client@362

@storyblok/nuxt

npm i https://pkg.pr.new/@storyblok/nuxt@362

@storyblok/react

npm i https://pkg.pr.new/@storyblok/react@362

@storyblok/region-helper

npm i https://pkg.pr.new/@storyblok/region-helper@362

@storyblok/richtext

npm i https://pkg.pr.new/@storyblok/richtext@362

@storyblok/svelte

npm i https://pkg.pr.new/@storyblok/svelte@362

@storyblok/vue

npm i https://pkg.pr.new/@storyblok/vue@362

commit: d8ba7b7

@maoberlehner maoberlehner merged commit 42dc1dd into main Oct 24, 2025
5 checks passed
@maoberlehner maoberlehner deleted the bugfix/types branch October 24, 2025 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants