-
-
Notifications
You must be signed in to change notification settings - Fork 268
feat(cli): added parser arg #2737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@mnaumanali94 I was having trouble fixing the commit message issues so I reopened a new PR instead. Sorry for the confusion. I've addressed the lint issues, but I'm having trouble getting all tests to work as well as adding appropriate tests of my own. Would love some help if you have time as I haven't worked with test-harness before and can't seem to get them to run locally in dev-container. |
|
@rudfoss-rr So to run harness tests you first need to build the binaries. For that cd into the package/cli folder and run |
Thanks! I've updated tests and attempted to add a few scenarios of my own, but was unable to completely rebuild the scenario tests using either I now see that I've broken a few other tests, but I'm not sure exactly why. If you could have a look and point me in the right direction that would be great! |
|
@rudfoss-rr this hasn't been addressed, correct? I still see the warnings for \t in json files |
|
@sbstnkr Yes, that is right. But I was unable to get the tests working and had to move on to other work so I closed it to avoid polluting the project with a broken PR. |
|
@rudfoss-rr could you please create another PR? 🙏🏼 |
Checklist
Does this PR introduce a breaking change?
Additional context
Suggestion for adding support for a
parserargument to the CLI so that the appropriate parser can be selected for Json files.