-
Notifications
You must be signed in to change notification settings - Fork 207
fix(auth): import all LinkedIn cookies in cross-platform bridge #217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
andrema2
wants to merge
14
commits into
stickerdaniel:main
Choose a base branch
from
andrema2:feature/216-import-all-linkedin-cookies
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
42039a8
Update README.md
andrema2 ec02fdf
novos mcps
andrema2 152f72d
ok
andrema2 fa220d1
testes
andrema2 3c0b2b1
feat(posts): improve unreplied comments detection and scraping
andrema2 034bdea
feat(scraping): add anti-blocking measures
andrema2 4e0de6b
Update AGENTS.md
andrema2 6fca3f7
feat(posts): add get_post_content tool
andrema2 e17ab74
Merge branch 'feature/get-post-content' into main
andrema2 63d76c4
feat(posts): add get_notifications tool
andrema2 c2eddcc
Merge branch 'feature/211-get-notifications'
andrema2 d4548f1
fix(scraping): address code review findings from Greptile
andrema2 64025a2
fix(auth): import all LinkedIn cookies in cross-platform bridge
andrema2 3532114
test(browser): add import_cookies unit tests and remove dead code
andrema2 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No unit tests for the new
import_cookiesbehaviorThe core fix of this PR — filtering cookies by domain instead of by name — has no dedicated unit tests. The only reference to
import_cookiesin the test suite (tests/test_browser_driver.py:40) mocks it out entirely (browser.import_cookies = AsyncMock(return_value=False)), so the new domain-filter logic and the updated required-cookie check are not exercised at all.Consider adding tests to
tests/test_browser_driver.py(or a newtests/test_core_browser.py) that cover at minimum:li_at) → should returnTrueand import all of them.li_atnorli_rm→ should returnFalse.False.Without these, a regression to the old name-based filtering (or a typo in the domain string) would go undetected.
Prompt To Fix With AI