Skip to content

Conversation

@al3bsi
Copy link
Contributor

@al3bsi al3bsi commented Feb 4, 2025

translate vod.ninja to arabic

@CLAassistant
Copy link

CLAassistant commented Feb 4, 2025

CLA assistant check
All committers have signed the CLA.

@al3bsi
Copy link
Contributor Author

al3bsi commented Feb 4, 2025

wating for add arabic language

@steveseguin steveseguin merged commit 5acc14e into steveseguin:develop Feb 5, 2025
1 check passed
@steveseguin
Copy link
Owner

Thank you for your submission.

I've corrected some JSON errors, and added support for this to vdo.ninja.

@al3bsi
Copy link
Contributor Author

al3bsi commented Feb 5, 2025

"Arabic language is not appearing in the languages list. Are there any steps I need to take first?"
‏لقطة الشاشة 1446-08-06 في 8 05 36 ص

@steveseguin
Copy link
Owner

Apologies. Try a hard page refresh. Pressing Control + F5 usually does it.

@al3bsi
Copy link
Contributor Author

al3bsi commented Feb 5, 2025

"Great, it's working now! However, as you know, languages written from right to left face challenges due to their differences from Latin-based languages. Texts often appear reversed and require direction adjustments. I hope your project includes a solution for this issue. There is a temporary fix using a Chrome browser extension, but we need a permanent solution to ensure Arabic texts display correctly."

‏لقطة الشاشة 1446-08-06 في 8 34 34 ص ‏لقطة الشاشة 1446-08-06 في 8 34 21 ص

@steveseguin
Copy link
Owner

I've made a change to vdo.ninja/alpha/. It's not perfect, but I think it's an improvement? I'm not sure though.

image

@al3bsi
Copy link
Contributor Author

al3bsi commented Feb 5, 2025

"It's really great, excellent work, and it serves the purpose for now. However, I noticed that some phrases were not translated. How can I update the translation file? Also, there's an issue with mobile browsers where the translation option doesn't appear, which forced me to add the suffix &ln=ar. Is there a way to detect the language automatically without adding the suffix every time?"

@steveseguin
Copy link
Owner

&ln=auto I think might auto-select the language, based on system settings, but it might not work in all cases. I don't do this automatically as many people prefer english, even if they have their system set to another language.

As per updating the translations some more, I did that for you just now I think. Let me know if there's an issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants