Fix API response parsing in retrieve_historical_rates function#61
Open
Javdat wants to merge 1 commit intostevecondylios:masterfrom
Open
Fix API response parsing in retrieve_historical_rates function#61Javdat wants to merge 1 commit intostevecondylios:masterfrom
Javdat wants to merge 1 commit intostevecondylios:masterfrom
Conversation
Update retrieve_historical_rates to handle changed exchangerate.host API response structure. Replace hard-coded numeric index access with named field access to prevent "subscript out of bounds" errors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes #60 where convert_currencies() was failing with "subscript out of bounds" error when accessing
dat[[8]]in the retrieve_historical_rates function.Changes:
dat[[8]]references withdat$quotesfor accessing exchange rate dataThe exchangerate.host API response structure has changed from using numeric indices to named fields. This update ensures the package works with the current API format while being more maintainable for future
changes.
Fixes the error reported when running:
Tested with R 4.5.0 and priceR 1.0.2.