Skip to content

Fix counter issues on VS platform#30

Closed
stephenxs wants to merge 5 commits intomasterfrom
fix-query-stat
Closed

Fix counter issues on VS platform#30
stephenxs wants to merge 5 commits intomasterfrom
fix-query-stat

Conversation

@stephenxs
Copy link
Owner

@stephenxs stephenxs commented Feb 21, 2025

Fix two day 1 counter issues on VS platform which have been exposed recently.

  1. Use switch object to detect counter capability in flex counter. This is to fix the following error message

    E               2025 Feb 20 15:43:21.906623 vlab-03 ERR syncd#syncd: :- queryStatsCapability: parameter switchId oid:0x100000001 object type is SAI_OBJECT_TYPE_PORT, but expected SAI_OBJECT_TYPE_SWITCH
    E               
    E               2025 Feb 20 15:43:21.910428 vlab-03 ERR syncd#syncd: :- queryStatsCapability: parameter switchId oid:0x1500000003 object type is SAI_OBJECT_TYPE_QUEUE, but expected SAI_OBJECT_TYPE_SWITCH
    
  2. Support PFC counters on VS platform
    Previously it didn't check counter capability before polling PFC counters by mistake.

Signed-off-by: Stephen Sun <stephens@nvidia.com>
Signed-off-by: Stephen Sun <stephens@nvidia.com>
Signed-off-by: Stephen Sun <stephens@nvidia.com>
Signed-off-by: Stephen Sun <stephens@nvidia.com>
@stephenxs stephenxs force-pushed the fix-query-stat branch 3 times, most recently from 225c5e8 to a76b8e4 Compare February 23, 2025 11:11
@stephenxs stephenxs changed the title Use switch object to detect counter capability in flex counter Fix counter issues on VS platform Feb 23, 2025
Signed-off-by: Stephen Sun <stephens@nvidia.com>
@stephenxs
Copy link
Owner Author

ci 528 + rerun 624 passed

@stephenxs stephenxs closed this Feb 24, 2025
stephenxs pushed a commit that referenced this pull request Mar 1, 2025
[202412] Fix bad merge from automation PR #24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants