Skip to content

[Mellanox] Return N/A for PSU's model, serial and revision on platforms with fixed PSU#73

Closed
stephenxs wants to merge 1 commit intomasterfrom
fix-field-miss-vpd
Closed

[Mellanox] Return N/A for PSU's model, serial and revision on platforms with fixed PSU#73
stephenxs wants to merge 1 commit intomasterfrom
fix-field-miss-vpd

Conversation

@stephenxs
Copy link
Owner

Signed-off-by: Stephen Sun stephens@nvidia.com

Why I did it

The methods get_model, get_serial, and get_revision have been implemented by reading relevant information from VPD and then recording the information into relevant fields.
However, there is no VPD data on platforms with fixed PSUs and relevant fields haven't been initialized, which causes the methods to throw exceptions. which in turn prevents psud from inserting fields into PSU table.
Eventually, this causes show platform psustatus doesn't output correct info.

admin@sonic:~$ show platform psustatus 
PSU    Model    Serial    HW Rev    Voltage (V)    Current (A)    Power (W)    Status    LED
-----  -------  --------  --------  -------------  -------------  -----------  --------  -----
PSU 1                                                                          OK        green
PSU 2                                                                          OK        green

How I did it

Initliaze those fields as N/A on systems with fixed PSUs.

How to verify it

Manually test.

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012

Description for the changelog

A picture of a cute animal (not mandatory but encouraged)

Signed-off-by: Stephen Sun <stephens@nvidia.com>
@stephenxs stephenxs changed the title [Mellanox] Return N/A for SKUs with fixed PSU in method get_ [Mellanox] Return N/A for PSU's model, serial and revision on platforms with fixed PSU Jun 21, 2021
@stephenxs stephenxs closed this Jun 21, 2021
stephenxs pushed a commit that referenced this pull request May 31, 2022
[sonic-linkmgrd][master] submodule updates

d744bfb Longxiang Lyu Wed May 25 08:40:42 2022 +0800 Support switch between using wellknown mac or server mac addr (#73)
684e989 Jing Zhang Wed May 18 09:59:02 2022 -0700 Avoid switching active when LinkState == Down (#77)
e4aa4fd Longxiang Lyu Tue May 17 09:13:23 2022 +0800 [Makefile] Remove redundant optimization options (#75)
4ec7505 Jing Zhang Thu May 12 08:19:20 2022 -0700 [ci]: uplift diff coverage threshold to 80% (#71)

sign-off: Jing Zhang zhangjing@microsoft.com
stephenxs pushed a commit that referenced this pull request May 16, 2023
a24412c25 (HEAD, origin/master, origin/HEAD, master) [mka]: Fix unexpected cleanup (#73)
26d1da0bc [mka]: Fix re-establishment by reset MI (#72)

Signed-off-by: Ze Gan <ganze718@gmail.com>
stephenxs pushed a commit that referenced this pull request Jul 23, 2025
…ically (sonic-net#23211)

#### Why I did it
src/sonic-dash-ha
```
* ff1b02a - (HEAD -> master, origin/master, origin/HEAD) Implement HA-Scope actor (#73) (20 hours ago) [yue-fred-gao]
* 832e67a - Implement HA-SET actor (#70) (4 days ago) [yue-fred-gao]
* cadfa46 - Implement vdpu actor (#67) (5 days ago) [yue-fred-gao]
```
#### How I did it
#### How to verify it
#### Description for the changelog
stephenxs pushed a commit that referenced this pull request Nov 19, 2025
…ly (sonic-net#24533)

#### Why I did it
src/sonic-stp
```
* d30e086 - (HEAD -> master, origin/master, origin/HEAD) Fix issues with PDU structure alignment, IPC msg processing (#73) (4 days ago) [Yogapriya-cisco]
```
#### How I did it
#### How to verify it
#### Description for the changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants