work around context loss with async-listener #21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[async-listener][1] is important module for APM tools and for long stack traces. Promises make the concept of a long-stack-trace ambiguous – as you can conceive the `then` callback as a continuation of either the resolution context or the context that queued the `then` callback ([more details][2]). async-listener defaults to the resolution context. This is the wrong default for how we are using promises here, resuling in APM tools like Stackdriver Trace losing context. We work-around the problem by not using the promise after it has resolved. [1]: https://www.npmjs.com/package/async-listener [2]: othiym23/node-continuation-local-storage#64
matthewloring
approved these changes
Jun 21, 2017
matthewloring
left a comment
matthewloring
left a comment
There was a problem hiding this comment.
Hopefully soon everything can just be async/await and we'll have async-hooks to prevent the need for these kinds of patterns.
Owner
|
This is some crazy stuff, but I trust you. |
Owner
|
Out in 0.7.1. |
This was referenced Jun 22, 2017
ofrobots
added a commit
to ofrobots/google-auto-auth
that referenced
this pull request
Jul 21, 2017
I believe this got broken by stephenplusplus#21.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
async-listener is important module for APM tools and for long
stack traces. Promises make the concept of a long-stack-trace ambiguous
– as you can conceive the
thencallback as a continuation of eitherthe resolution context or the context that queued the
thencallback (more details).
async-listener defaults to the resolution context. This is the wrong
default for how we are using promises here, resuling in APM tools
like Stackdriver Trace losing context.
We work-around the problem by not using the promise after it has
resolved.
R= @matthewloring