Skip to content

[internal][config/main] enable systemd debug logs on reload #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
stepanblyschak wants to merge 1 commit into from
Closed

[internal][config/main] enable systemd debug logs on reload #95

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions config/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,11 @@
GRE_TYPE_RANGE = click.IntRange(min=0, max=65535)
ADHOC_VALIDATION = True

if not os.environ.get("UTILITIES_UNIT_TESTING"):
SYSTEMD_ENABLE_DEBUG_LOGS = True
else:
SYSTEMD_ENABLE_DEBUG_LOGS = False

if os.environ.get("UTILITIES_UNIT_TESTING", "0") in ("1", "2"):
temp_system_reload_lockfile = tempfile.NamedTemporaryFile()
SYSTEM_RELOAD_LOCK = temp_system_reload_lockfile.name
Expand Down Expand Up @@ -969,6 +974,10 @@ def _get_disabled_services_list(config_db):


def _stop_services():
if SYSTEMD_ENABLE_DEBUG_LOGS:
log.log_notice("Enabling systemd debug logs")
clicommon.run_command(["systemd-analyze", "log-level", "debug"], display_cmd=True)

try:
subprocess.check_call(['sudo', 'monit', 'status'], stdout=subprocess.DEVNULL, stderr=subprocess.DEVNULL)
click.echo("Disabling container and routeCheck monitoring ...")
Expand All @@ -980,6 +989,17 @@ def _stop_services():
click.echo("Stopping SONiC target ...")
clicommon.run_command(['sudo', 'systemctl', 'stop', 'sonic.target', '--job-mode', 'replace-irreversibly'])

if SYSTEMD_ENABLE_DEBUG_LOGS:
for iteration in range(5):
out, _ = clicommon.run_command(['sudo', 'systemctl', 'is-active', 'sonic.target'], display_cmd=True, return_cmd=True)
out = out.strip()
if out != "inactive":
log.log_error("--- REPRODUCE --- Failed to stop sonic.target, probably it started again, state: {}".format(out))
sys.exit(1)
else:
log.log_notice("--- DEBUG --- sonic.target is inactive, waiting for 1 second, iteration: {}".format(iteration))
time.sleep(1)


def _get_sonic_services():
cmd = ['systemctl', 'list-dependencies', '--plain', 'sonic.target']
Expand Down Expand Up @@ -1043,6 +1063,10 @@ def _restart_services():
click.echo("Reloading Monit configuration ...")
clicommon.run_command(['sudo', 'monit', 'reload'])

if SYSTEMD_ENABLE_DEBUG_LOGS:
log.log_notice("Disabling systemd debug logs")
clicommon.run_command(["systemd-analyze", "log-level", "info"], display_cmd=True)

def _per_namespace_swss_ready(service_name):
out, _ = clicommon.run_command(['systemctl', 'show', str(service_name), '--property', 'ActiveState', '--value'], return_cmd=True)
if out.strip() != "active":
Expand Down
Loading