[warm/fast-reboot] fix lag_keepalive.py hang#93
Closed
stepanblyschak wants to merge 1 commit intomasterfrom
Closed
[warm/fast-reboot] fix lag_keepalive.py hang#93stepanblyschak wants to merge 1 commit intomasterfrom
stepanblyschak wants to merge 1 commit intomasterfrom
Conversation
Signed-off-by: Stepan Blyschak <[email protected]>
volodymyrsamotiy
approved these changes
Apr 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Issue introduced in
https://github.com/sonic-net/sonic-utilities/pull/3170lag_keepalive invokes teamdctl which is a wrapper around docker exec -i. This command is known to not work togather with timeout and similar issues have been fixed before -
https://github.com/sonic-net/sonic-utilities/pull/1904How I did it
Add
--foregroundoption for timeout to receive TTY signals.How to verify it
Run warm or fast reboot.
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)