[db_migrator] fix old 1911 feature config migration to a new one.#20
Closed
stepanblyschak wants to merge 1 commit intomasterfrom
Closed
[db_migrator] fix old 1911 feature config migration to a new one.#20stepanblyschak wants to merge 1 commit intomasterfrom
stepanblyschak wants to merge 1 commit intomasterfrom
Conversation
This change is in addition to sonic-net#1522. The init_cfg.json may have important fields added to configuration, while in previous fix these entries will not be added when table already exists. This change fixes this behaviour. Also, in order to preserve users auto_restart configuration a special logic for migrating CONTAINER_FEATURE table has been implemented. A test to cover this scenario is added. Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
stepanblyschak
force-pushed
the
fix-init-cfg-migration
branch
from
63a4c35 to
4f21a0e
Compare
volodymyrsamotiy
approved these changes
May 19, 2021
stepanblyschak
commented
May 19, 2021
| for init_table_key, init_table_val in table_val.items(): | ||
| self.configDB.set_entry(init_cfg_table, init_table_key, init_table_val) | ||
| for key in table_val: | ||
| curr_cfg = self.configDB.get_entry(init_cfg_table, key) |
Owner
Author
There was a problem hiding this comment.
get_entry() returns None or {}
Owner
Author
There was a problem hiding this comment.
Returns {}, all is good
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is in addition to sonic-net#1522.
The init_cfg.json may have important fields added to configuration, while in
previous fix these entries will not be added when table already exists.
This change fixes this behaviour. Also, in order to preserve users auto_restart
configuration a special logic for migrating CONTAINER_FEATURE table has been implemented.
A test to cover this scenario is added.
Signed-off-by: Stepan Blyschak stepanb@nvidia.com
What I did
How I did it
How to verify it
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)