Skip to content

[teamd] Stop teamd after stopping swss in fast-reboot#75

Closed
stepanblyschak wants to merge 1 commit intomasterfrom
stop-bgp-before-teamd
Closed

[teamd] Stop teamd after stopping swss in fast-reboot#75
stepanblyschak wants to merge 1 commit intomasterfrom
stop-bgp-before-teamd

Conversation

@stepanblyschak
Copy link
Copy Markdown
Owner

@stepanblyschak stepanblyschak commented Jun 20, 2022

Signed-off-by: Stepan Blyschak stepanb@nvidia.com

Why I did it

To optimize fast-reboot. Teamd can be stopped after bgp is stopped and after swss is stopped because the last LACP packet can be sent still since syncd is still running. Saves 15 sec on shutdown.

How I did it

Defined in the manifest for teamd to be stopped after swss

How to verify it

Run it on the switch.

Before;

Mon 20 Jun 2022 03:53:07 PM UTC Saving counters folder before warmboot...
Mon 20 Jun 2022 03:53:10 PM UTC Prepare MLNX ASIC to fast-reboot: install new FW if required
Mon 20 Jun 2022 03:53:13 PM UTC Collecting logs to check ssd health before fast-reboot...
Mon 20 Jun 2022 03:53:13 PM UTC Stopping lldp.timer ...
Mon 20 Jun 2022 03:53:13 PM UTC Stopped lldp.timer ...
Mon 20 Jun 2022 03:53:13 PM UTC Stopping mgmt-framework.timer ...
Mon 20 Jun 2022 03:53:13 PM UTC Stopped mgmt-framework.timer ...
Mon 20 Jun 2022 03:53:13 PM UTC Stopping pmon.timer ...
Mon 20 Jun 2022 03:53:14 PM UTC Stopped pmon.timer ...
Mon 20 Jun 2022 03:53:14 PM UTC Stopping snmp.timer ...
Mon 20 Jun 2022 03:53:14 PM UTC Stopped snmp.timer ...
Mon 20 Jun 2022 03:53:14 PM UTC Stopping telemetry.timer ...
Mon 20 Jun 2022 03:53:14 PM UTC Stopped telemetry.timer ...
Mon 20 Jun 2022 03:53:14 PM UTC Stopping what-just-happened.timer ...
Mon 20 Jun 2022 03:53:14 PM UTC Stopped what-just-happened.timer ...
Mon 20 Jun 2022 03:53:14 PM UTC Stopping lldp ...
Mon 20 Jun 2022 03:53:15 PM UTC Stopped lldp
Mon 20 Jun 2022 03:53:15 PM UTC Stopping mux ...
Warning: The unit file, source configuration file or drop-ins of mux.service changed on disk. Run 'systemctl daemon-reload' to reload units.
Mon 20 Jun 2022 03:53:15 PM UTC Stopped mux
Mon 20 Jun 2022 03:53:15 PM UTC Stopping nat ...
Dumping conntrack entries failed
Warning: The unit file, source configuration file or drop-ins of nat.service changed on disk. Run 'systemctl daemon-reload' to reload units.
Mon 20 Jun 2022 03:53:15 PM UTC Stopped nat
Mon 20 Jun 2022 03:53:15 PM UTC Stopping radv ...
Mon 20 Jun 2022 03:53:16 PM UTC Stopped radv
Mon 20 Jun 2022 03:53:16 PM UTC Stopping sflow ...
Warning: The unit file, source configuration file or drop-ins of sflow.service changed on disk. Run 'systemctl daemon-reload' to reload units.
Mon 20 Jun 2022 03:53:17 PM UTC Stopped sflow
Mon 20 Jun 2022 03:53:17 PM UTC Stopping teamd ...
Mon 20 Jun 2022 03:53:18 PM UTC Stopped teamd
Mon 20 Jun 2022 03:53:18 PM UTC Stopping bgp ...
Mon 20 Jun 2022 03:53:23 PM UTC Stopped bgp
Mon 20 Jun 2022 03:53:23 PM UTC Stopping swss ...
Mon 20 Jun 2022 03:53:33 PM UTC Stopped swss
Mon 20 Jun 2022 03:53:33 PM UTC Stopping syncd ...
Mon 20 Jun 2022 03:53:43 PM UTC Stopped syncd
Mon 20 Jun 2022 03:53:43 PM UTC Stopping all remaining containers ...
Mon 20 Jun 2022 03:53:47 PM UTC Stopped all remaining containers ...
Warning: Stopping docker.service, but it can still be activated by:
  docker.socket
Mon 20 Jun 2022 03:53:48 PM UTC Enabling Watchdog before fast-reboot
Watchdog armed for 180 seconds
Mon 20 Jun 2022 03:53:48 PM UTC Rebooting with /sbin/kexec -e to SONiC-OS-202111.82-3dacfea43_Internal ...

After:

Tue 21 Jun 2022 03:35:34 PM UTC Saving counters folder before warmboot...
Tue 21 Jun 2022 03:35:38 PM UTC Prepare MLNX ASIC to fast-reboot: install new FW if required
Tue 21 Jun 2022 03:35:40 PM UTC Collecting logs to check ssd health before fast-reboot...
Tue 21 Jun 2022 03:35:41 PM UTC Stopping lldp.timer ...
Tue 21 Jun 2022 03:35:41 PM UTC Stopped lldp.timer ...
Tue 21 Jun 2022 03:35:41 PM UTC Stopping mgmt-framework.timer ...
Tue 21 Jun 2022 03:35:41 PM UTC Stopped mgmt-framework.timer ...
Tue 21 Jun 2022 03:35:41 PM UTC Stopping pmon.timer ...
Tue 21 Jun 2022 03:35:41 PM UTC Stopped pmon.timer ...
Tue 21 Jun 2022 03:35:41 PM UTC Stopping snmp.timer ...
Tue 21 Jun 2022 03:35:41 PM UTC Stopped snmp.timer ...
Tue 21 Jun 2022 03:35:41 PM UTC Stopping telemetry.timer ...
Tue 21 Jun 2022 03:35:41 PM UTC Stopped telemetry.timer ...
Tue 21 Jun 2022 03:35:41 PM UTC Stopping what-just-happened.timer ...
Tue 21 Jun 2022 03:35:41 PM UTC Stopped what-just-happened.timer ...
Tue 21 Jun 2022 03:35:41 PM UTC Stopping pmon ...
Tue 21 Jun 2022 03:35:44 PM UTC Stopped pmon
Tue 21 Jun 2022 03:35:44 PM UTC Stopping lldp ...
Tue 21 Jun 2022 03:35:46 PM UTC Stopped lldp
Tue 21 Jun 2022 03:35:46 PM UTC Stopping mux ...
Warning: The unit file, source configuration file or drop-ins of mux.service changed on disk. Run 'systemctl daemon-reload' to reload units.
Tue 21 Jun 2022 03:35:46 PM UTC Stopped mux
Tue 21 Jun 2022 03:35:46 PM UTC Stopping nat ...
Dumping conntrack entries failed
Warning: The unit file, source configuration file or drop-ins of nat.service changed on disk. Run 'systemctl daemon-reload' to reload units.
Tue 21 Jun 2022 03:35:47 PM UTC Stopped nat
Tue 21 Jun 2022 03:35:47 PM UTC Stopping radv ...
Tue 21 Jun 2022 03:35:47 PM UTC Stopped radv
Tue 21 Jun 2022 03:35:48 PM UTC Stopping sflow ...
Warning: The unit file, source configuration file or drop-ins of sflow.service changed on disk. Run 'systemctl daemon-reload' to reload units.
Tue 21 Jun 2022 03:35:48 PM UTC Stopped sflow
Tue 21 Jun 2022 03:35:48 PM UTC Stopping bgp ...
Tue 21 Jun 2022 03:35:53 PM UTC Stopped bgp
Tue 21 Jun 2022 03:35:53 PM UTC Stopping swss ...
Tue 21 Jun 2022 03:36:03 PM UTC Stopped swss
Tue 21 Jun 2022 03:36:03 PM UTC Stopping teamd ...
Tue 21 Jun 2022 03:36:04 PM UTC Stopped teamd
Tue 21 Jun 2022 03:36:04 PM UTC Stopping syncd ...
Tue 21 Jun 2022 03:36:10 PM UTC Stopped syncd
Tue 21 Jun 2022 03:36:10 PM UTC Stopping all remaining containers ...
Tue 21 Jun 2022 03:36:14 PM UTC Stopped all remaining containers ...
Warning: Stopping docker.service, but it can still be activated by:
  docker.socket
Tue 21 Jun 2022 03:36:15 PM UTC Enabling Watchdog before fast-reboot
Watchdog armed for 180 seconds
Tue 21 Jun 2022 03:36:15 PM UTC Rebooting with /sbin/kexec -e to SONiC-OS-202111.83-8d72c484f_Internal ...

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
@stepanblyschak stepanblyschak force-pushed the stop-bgp-before-teamd branch from fb3adba to 050884b Compare June 21, 2022 12:33
@stepanblyschak stepanblyschak changed the title [bgp/teamd] Stop bgp before stopping teamd in fast-reboot [teamd] Stop teamd before stopping swss in fast-reboot Jun 21, 2022
@stepanblyschak stepanblyschak changed the title [teamd] Stop teamd before stopping swss in fast-reboot [teamd] Stop teamd after stopping swss in fast-reboot Jun 21, 2022
stepanblyschak pushed a commit that referenced this pull request Jul 6, 2022
[sonic-linkmgrd][master] submodule updates

d744bfb Longxiang Lyu Wed May 25 08:40:42 2022 +0800 Support switch between using wellknown mac or server mac addr (#73)
684e989 Jing Zhang Wed May 18 09:59:02 2022 -0700 Avoid switching active when LinkState == Down (#77)
e4aa4fd Longxiang Lyu Tue May 17 09:13:23 2022 +0800 [Makefile] Remove redundant optimization options (#75)
4ec7505 Jing Zhang Thu May 12 08:19:20 2022 -0700 [ci]: uplift diff coverage threshold to 80% (#71)

sign-off: Jing Zhang zhangjing@microsoft.com
stepanblyschak pushed a commit that referenced this pull request Sep 25, 2023
…utomatically (sonic-net#16670)

#### Why I did it
src/sonic-host-services
```
* 3022c1b - (HEAD -> master, origin/master, origin/HEAD) Updated the iptable rule to use parent/base name of midplane interface of chassis. (#75) (6 hours ago) [abdosi]
```
#### How I did it
#### How to verify it
#### Description for the changelog
stepanblyschak pushed a commit that referenced this pull request Dec 19, 2023
…utomatically (sonic-net#17229)

#### Why I did it
src/sonic-host-services
```
* 689395a - (HEAD -> 202305, origin/202305) Updated the iptable rule to use parent/base name of midplane interface of chassis. (#75) (2 days ago) [abdosi]
* 45212a8 - [DualToR][caclmgrd] Fix IPtables rules for multiple vlan interfaces for DualToR config (#82) (2 days ago) [vdahiya12]
```
#### How I did it
#### How to verify it
#### Description for the changelog
stepanblyschak pushed a commit that referenced this pull request May 20, 2025
… automatically (sonic-net#945)

#### Why I did it
src/sonic-platform-common
```
* 42d0124 - (HEAD -> 202412, origin/202412) [CMIS] Add Changes to align the RX disable channel logic with the existing TX disable channel implementation (#75) (3 hours ago) [mssonicbld]
```
#### How I did it
#### How to verify it
#### Description for the changelog
stepanblyschak pushed a commit that referenced this pull request May 20, 2025
…tomatically (sonic-net#1063)

#### Why I did it
src/sonic-swss
```
* 3b70292 - (HEAD -> 202412, origin/202412) Move timestamps out of counter table to avoid update too frequently (#75) (21 hours ago) [mssonicbld]
```
#### How I did it
#### How to verify it
#### Description for the changelog
stepanblyschak pushed a commit that referenced this pull request Sep 28, 2025
…ly (sonic-net#24100)

#### Why I did it
src/dhcprelay
```
* 0ef56c0 - (HEAD -> master, origin/master, origin/HEAD) [codeQL] Fix codeQL failure (#75) (18 hours ago) [Yaqiang Zhu]
```
#### How I did it
#### How to verify it
#### Description for the changelog
stepanblyschak pushed a commit that referenced this pull request Dec 1, 2025
…ically (sonic-net#24555)

#### Why I did it
src/sonic-dbsyncd
```
* 2f0af22 - (HEAD -> master, origin/master, origin/HEAD) Add chassis cache update (#75) (2 days ago) [Gagan Punathil Ellath]
```
#### How I did it
#### How to verify it
#### Description for the changelog
stepanblyschak pushed a commit that referenced this pull request Dec 1, 2025
…ly (sonic-net#24633)

#### Why I did it
src/sonic-stp
```
* 49c02e5 - (HEAD -> master, origin/master, origin/HEAD) Migrate agent pool from ubuntu-20.04 to ubuntu-latest (#74) (25 minutes ago) [yijingyan2]
* 6dc2791 - Enable proto_mode handling code (#75) (2 days ago) [Divya Kumaran Chandralekha]
```
#### How I did it
#### How to verify it
#### Description for the changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants