[teamd/patch] do not send LACP PDU if link is down#34
Closed
stepanblyschak wants to merge 1 commit intomasterfrom
Closed
[teamd/patch] do not send LACP PDU if link is down#34stepanblyschak wants to merge 1 commit intomasterfrom
stepanblyschak wants to merge 1 commit intomasterfrom
Conversation
Otherwise the lacp_port_set_state() returns error when called from lacp_port_link_update() and lead to not up-to-date cache in lacp_port->__link_last. This can happen when member flapping happens. When this issue happens the condition comparing lacp_port->__link_last to current linkup in lacp_port_link_update() will not pass and member will never get out of deselected state unless it is flapped again. This is done as a fix in patch maintained by SONiC but planned to be upstreamed in libteam as well. Currently we cannot simply propose this fix in libteam and use libteam master as of important bug fix revert in jpirko/libteam 61efd6de2fbb8ee077863ee5a355ac3dfd9365b9. Signed-off-by: Stepan Blyschak <[email protected]>
volodymyrsamotiy
approved these changes
Apr 20, 2021
stepanblyschak
pushed a commit
that referenced
this pull request
Mar 26, 2025
…tically (sonic-net#22051) #### Why I did it src/sonic-dash-api ``` * 5c5aa8a - (HEAD -> master, origin/master, origin/HEAD) Add outbound_direction_lookup to dash appliance table (#32) (7 days ago) [prabhataravind] * a662860 - Add tunnel field to route message (#34) (8 days ago) [Lawrence Lee] ``` #### How I did it #### How to verify it #### Description for the changelog
stepanblyschak
pushed a commit
that referenced
this pull request
Apr 2, 2025
…sonic-net#21818) #### Why I did it src/dhcpmon ``` * 2519a88 - (HEAD -> 202411, origin/202411) Merge pull request #34 from yaqiangz/202411_dhcpmon_bootp (2 days ago) [Kumaresh Perumal] * 3e58f23 - Fix counting bootp packets by mistake (#31) (3 days ago) [Yaqiang Zhu] ``` #### How I did it #### How to verify it #### Description for the changelog
stepanblyschak
pushed a commit
that referenced
this pull request
May 20, 2025
…lly (sonic-net#634) #### Why I did it src/sonic-swss ``` * b2a7b03 - (HEAD -> 202412, origin/202412) [code sync] Merge code from sonic-net/sonic-swss:202411 to 202412 (#36) (7 hours ago) [mssonicbld] * 84485cd - [code sync] Merge code from sonic-net/sonic-swss:202411 to 202412 (#35) (31 hours ago) [mssonicbld] * 6e83557 - [code sync] Merge code from sonic-net/sonic-swss:202411 to 202412 (#34) (2 days ago) [mssonicbld] ``` #### How I did it #### How to verify it #### Description for the changelog
stepanblyschak
pushed a commit
that referenced
this pull request
May 20, 2025
… automatically (sonic-net#672) #### Why I did it src/sonic-platform-common ``` * 26e5980 - (HEAD -> 202412, origin/202412) [code sync] Merge code from sonic-net/sonic-platform-common:202411 to 202412 (#34) (55 minutes ago) [mssonicbld] ``` #### How I did it #### How to verify it #### Description for the changelog
stepanblyschak
pushed a commit
that referenced
this pull request
May 20, 2025
…tomatically (sonic-net#853) #### Why I did it src/sonic-linux-kernel ``` * c2f3387 - (HEAD -> 202412, origin/HEAD, origin/202412) [code sync] Merge code from sonic-net/sonic-linux-kernel:202411 to 202412 (#34) (21 hours ago) [mssonicbld] ``` #### How I did it #### How to verify it #### Description for the changelog
stepanblyschak
pushed a commit
that referenced
this pull request
May 20, 2025
…omatically (sonic-net#878) #### Why I did it src/sonic-swss-common ``` * 97af2db - (HEAD -> 202412, origin/HEAD, origin/202412) [FC] remove FLEX_COUNTER_DELAY_STATUS_FIELD (sonic-net#982) (#34) (21 hours ago) [mssonicbld] ``` #### How I did it #### How to verify it #### Description for the changelog
stepanblyschak
pushed a commit
that referenced
this pull request
Dec 24, 2025
The version of systemd on Trixie no longer allows service generators to write to directories outside of what has been explicitly passed in. This affects DPU and multi-ASIC use cases. Therefore, rework systemd-sonic-generator to meet these requirements. Also, compile systemd-sonic-generator with C++17. The gtest headers no longer support C++11, so it needs to be bumped up to C++14 at minimum. Also, move logs for systemd-sonic-generator into /dev/kmsg (#34) Co-authored-by: Hemanth Kumar Tirupati <[email protected]> Signed-off-by: Saikrishna Arcot <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otherwise the lacp_port_set_state() returns error when called from
lacp_port_link_update() and lead to not up-to-date cache in
lacp_port->__link_last. This can happen when member flapping happens.
When this issue happens the condition comparing lacp_port->__link_last
to current linkup in lacp_port_link_update() will not pass and member
will never get out of deselected state unless it is flapped again.
This is done as a fix in patch maintained by SONiC but planned to be
upstreamed in libteam as well. Currently we cannot simply propose this
fix in libteam and use libteam master as of important bug fix revert in
jpirko/libteam 61efd6de2fbb8ee077863ee5a355ac3dfd9365b9.
Signed-off-by: Stepan Blyschak [email protected]
Why I did it
How I did it
How to verify it
Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)