Skip to content

Update docusaurus deps#1087

Merged
jaredcbaum merged 3 commits into
mainfrom
chore/update-docusaurus-deps
Mar 30, 2023
Merged

Update docusaurus deps#1087
jaredcbaum merged 3 commits into
mainfrom
chore/update-docusaurus-deps

Conversation

@jaredcbaum
Copy link
Copy Markdown
Contributor

@jaredcbaum jaredcbaum commented Mar 30, 2023

This PR updates the docusaurus deps for the ionic docusaurus preset and the site.

@vercel
Copy link
Copy Markdown

vercel Bot commented Mar 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
stencil-docs ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 30, 2023 at 3:56PM (UTC)

@rwaskiewicz
Copy link
Copy Markdown
Member

LGTM!

It looks like in 2.4 they enabled pnpm support for npm2yarn. IDK if/when we'd wanna enable that, but just throwing it out there as food for thought

@rwaskiewicz
Copy link
Copy Markdown
Member

For posterity, I inspected the preview, the PR itself, and reviewed the changelog for docusaurus. Nothing new seems to affect us (except maybe the pnpm stuff I mentioned), Preview looks good, etc.

@jaredcbaum jaredcbaum merged commit 889df8a into main Mar 30, 2023
@jaredcbaum jaredcbaum deleted the chore/update-docusaurus-deps branch March 30, 2023 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants