Update docusaurus deps #1087
Merged
Update docusaurus deps #1087
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
|
LGTM! It looks like in 2.4 they enabled pnpm support for npm2yarn. IDK if/when we'd wanna enable that, but just throwing it out there as food for thought |
Contributor
|
For posterity, I inspected the preview, the PR itself, and reviewed the changelog for docusaurus. Nothing new seems to affect us (except maybe the pnpm stuff I mentioned), Preview looks good, etc. |
rwaskiewicz
approved these changes
Mar 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the docusaurus deps for the ionic docusaurus preset and the site.