Refactor RPC health check goroutines #381
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| case <-ticker.C: | ||
| _, err = s.RPCService.GetHealth() | ||
| if err == nil { | ||
| break |
Contributor
There was a problem hiding this comment.
can we use a label on this break? The nested breaks are easy to misinterpret.
aristidesstaffieri
approved these changes
Nov 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
serveprocess completely.GetHealthcall in channel account service.TrackRPCServiceHealthnow sends an error message on context cancellation which is handled by the ingestion process. We exit out of ingestion loop if RPC context is cancelled.Why
Bug fixes
Known limitations
N/A
Issue that this PR addresses
Closes #285