-
Notifications
You must be signed in to change notification settings - Fork 10
Add complete integration test suite for balances end-to-end testing #373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
aditya1702
wants to merge
9
commits into
graphql-balances-resolver
Choose a base branch
from
balances-integration-tests
base: graphql-balances-resolver
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // TestCheckpoint_HolderContract_HasInitialBalances verifies that the holder contract | ||
| // has the expected initial balances from checkpoint setup: | ||
| // - USDC SAC tokens (200) | ||
| // - SEP-41 contract tokens (300) |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NIT: looks like the balance is actually 500
| @@ -0,0 +1,298 @@ | |||
| // Account Balance Integration Tests | |||
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can this suite include tests for balances of 0?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add setup and fixtures to test the balances feature end to end. The following is added:
Why
Part of the account balances milestone: https://github.com/stellar/wallet-backend/milestone/13
Known limitations
N/A
Issue that this PR addresses
Closes #366