Add graphql schema definition for balances query #371
+2,499
−590
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| tokenType: TokenType! | ||
| } | ||
|
|
||
| type NativeBalance implements Balance { |
Contributor
There was a problem hiding this comment.
curious why the native balance would not just be a SACBalance?
Contributor
Author
There was a problem hiding this comment.
NativeBalance would not have the authorized and clawback fields right? It is extracted from the AccountEntry ledger entry which only has the actual balance: https://github.com/stellar/go/blob/474a86a2e96a/xdr/xdr_generated.go#L3831. So those would be specific to non-native SAC contracts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Why
Part of the account balances milestone: https://github.com/stellar/wallet-backend/milestone/13
Known limitations
N/A
Issue that this PR addresses
Closes #361