use redux selector for allAccounts to properly update rename

extension/e2e-tests/loadAccount.test.ts

@@ -657,3 +657,21 @@ test("Loads wallets data and token prices on Mainnet in batches", async ({
 
   expect(tokenPricesCallCount).toBe(7);
 });
+
+test("Renames wallets", async ({ page, extensionId, context }) => {
+  await stubTokenDetails(page);
+  await stubAccountHistory(page);
+  await stubTokenPrices(page);
+  await stubScanDapp(context);
+
+  await loginToTestAccount({ page, extensionId });
+  await page.getByTestId("account-view-account-name").click();
+  await expect(page.getByText("Wallets")).toBeVisible();
+
+  const walletRowOptions = await page.getByTestId("wallet-row-options").all();
+  await walletRowOptions[0].click();
+  await page.getByText("Rename wallet").click();
+  await page.getByTestId("rename-wallet-input").fill("New Wallet");
+  await page.getByText("Save").click();
+  await expect(page.getByText("New Wallet")).toBeVisible();
+});

extension/e2e-tests/sendPayment.test.ts

@@ -425,7 +425,7 @@ test("Send XLM payment to C address", async ({ page, extensionId }) => {
     timeout: 60000,
   });
 
-  await page.getByTestId(`SubmitAction`).click({ force: true });
+  await page.getByTestId(`SubmitAction`).click({ force: true, timeout: 60000 });
 
   let accountBalancesRequestWasMade = false;
   page.on("request", (request) => {
@@ -616,7 +616,7 @@ test("Send token payment to C address", async ({ page, extensionId }) => {
     timeout: 60000,
   });
 
-  await page.getByTestId(`SubmitAction`).click({ force: true });
+  await page.getByTestId(`SubmitAction`).click({ force: true, timeout: 60000 });
 
   let accountBalancesRequestWasMade = false;
   page.on("request", (request) => {

extension/src/popup/views/Wallets/index.tsx

@@ -23,6 +23,7 @@ import { IdenticonImg } from "popup/components/identicons/IdenticonImg";
 import {
   makeAccountActive,
   updateAccountName,
+  allAccountsSelector,
 } from "popup/ducks/accountServices";
 import { settingsNetworkDetailsSelector } from "popup/ducks/settings";
 import { clearBalancesForAccount } from "popup/ducks/cache";
@@ -39,9 +40,9 @@ import { AppDataType } from "helpers/hooks/useGetAppData";
 import { newTabHref } from "helpers/urls";
 import { navigateTo, openTab } from "popup/helpers/navigate";
 import { reRouteOnboarding } from "popup/helpers/route";
+import { WalletType } from "@shared/constants/hardwareWallet";
 
 import "./styles.scss";
-import { WalletType } from "@shared/constants/hardwareWallet";
 
 interface AddWalletProps {
   onBack: () => void;
@@ -163,6 +164,7 @@ const RenameWallet = ({
                   <Field name="accountName">
                     {({ field }: FieldProps) => (
                       <Input
+                        data-testid="rename-wallet-input"
                         autoFocus
                         fieldSize="md"
                         autoComplete="off"
@@ -273,6 +275,7 @@ const WalletRow = ({
       </div>
       <div
         className="WalletRow__options"
+        data-testid="wallet-row-options"
         onClick={() => setOptionsOpen(publicKey)}
       >
         <img src={IconEllipsis} alt="wallet action options" />
@@ -292,6 +295,7 @@ export const Wallets = () => {
     React.useState("");
   const { state: dataState, fetchData } = useGetWalletsData();
   const networkDetails = useSelector(settingsNetworkDetailsSelector);
+  const allAccounts = useSelector(allAccountsSelector);
 
   useEffect(() => {
     const getData = async () => {
@@ -363,11 +367,7 @@ export const Wallets = () => {
     );
   }
 
-  const {
-    allAccounts,
-    publicKey: activePublicKey,
-    accountValue,
-  } = dataState.data;
+  const { publicKey: activePublicKey, accountValue } = dataState.data;
 
   return (
     <React.Fragment>
@@ -402,6 +402,7 @@ export const Wallets = () => {
               return (
                 <>
                   <WalletRow
+                    key={publicKey}
                     isFetchingTokenPrices={isFetchingTokenPrices}
                     accountName={name}
                     accountValue={totalValueUsd}