Adds changes to fix witness_set_properties #514
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
starlord2826
force-pushed
the
fix-witness_set_properties
branch
from
f5f1e9c to
141a2ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The witness_set_properties operation requires each value in props to be serialized individually before serializing props as a FlatMap(StringSerializer, BinarySerializer). While the condenser API documentation shows props as an object, which simplifies working with the operation, it must be converted into an array by the transaction serializer/broadcaster before sending it to the node. If this conversion is not done, the transaction will not be accepted.
This can now be used to also broadcast the witness pricefeed using the witness private key itself.