Add preview and counters for CR system messages #16898 #3872
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Jenkins BuildsClick to see older builds (8)
|
MishkaRogachev
approved these changes
Aug 10, 2023
Contributor
MishkaRogachev
left a comment
MishkaRogachev
left a comment
There was a problem hiding this comment.
Great work! Here is one question you can ignore
protocol/messenger_handler.go
Outdated
| } | ||
| state.Response.AddMessage(updateMessage) | ||
|
|
||
| chat.UnviewedMessagesCount++ |
Contributor
There was a problem hiding this comment.
Isn't better to increase counter after UpdateFromMessage because it can exit with error here?
flexsurfer
force-pushed
the
feature/Add_preview_and_counters_for_CR_system_messages_#16898
branch
from
0c177e2 to
568e775
Compare
flexsurfer
force-pushed
the
feature/Add_preview_and_counters_for_CR_system_messages_#16898
branch
from
568e775 to
98a9e81
Compare
flexsurfer
deleted the
feature/Add_preview_and_counters_for_CR_system_messages_#16898
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add counters for "you were removed from contact" and "now is contact" system messages
Steps:
Add preview for "you were removed from contact"/"you removed from contact" system messages
status-react :status-im/status-legacy#16898