Skip to content

stop calling engine_exchangeTransitionConfigurationV1 with Dencun-ready ELs #5585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zah merged 1 commit into from
Nov 11, 2023
Merged

stop calling engine_exchangeTransitionConfigurationV1 with Dencun-ready ELs #5585

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions beacon_chain/el/el_manager.nim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1400,6 +1400,11 @@ proc exchangeConfigWithSingleEL(m: ELManager, connection: ELConnection) {.async.

connection.etcStatus = EtcStatus.match

# https://github.com/ethereum/execution-apis/blob/c4089414bbbe975bbc4bf1ccf0a3d31f76feb3e1/src/engine/cancun.md#deprecate-engine_exchangetransitionconfigurationv1
# Consensus layer clients MUST NOT call this method.
if m.eth1Chain.cfg.DENEB_FORK_EPOCH != FAR_FUTURE_EPOCH:
Copy link
Contributor

@zah zah Nov 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't the spec saying that the ELs should stop reporting an error message about this once the Cancun fork epoch is reached? The check here is doing something different.

Copy link
Contributor Author

@tersec tersec Nov 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I asked about this recently in an Eth R&D Discord thread in the #json-rpc-api channel:
when_stop_etc

return

# https://github.com/ethereum/execution-apis/blob/v1.0.0-beta.3/src/engine/paris.md#engine_exchangetransitionconfigurationv1
let
ourConf = TransitionConfigurationV1(
Expand Down