Skip to content

Conversation

@jasonvarga
Copy link
Member

@jasonvarga jasonvarga commented Aug 22, 2025

When you're working locally without https, the browser clipboard api doesn't work. The copy button would do nothing.
See #12074

This PR will hide the button in that case.

This PR also does some necessary clean up to Input component.

  • hasPrependedIcon and hasAppendedIcon are computeds which allows it to adapt to prop changes (and so we can use the copyable computed in it)
  • iconClasses is a computed (like inputClasses already was) and performs twMerge. The large diff there is really due to indentation.
  • inputClasses and iconClasses use .value because they now reference computeds
  • Removed unnecessary .value usage from the template

@jasonvarga jasonvarga merged commit fe1a04f into master Aug 22, 2025
20 checks passed
@jasonvarga jasonvarga deleted the copy-non-https branch August 22, 2025 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants