-
-
Notifications
You must be signed in to change notification settings - Fork 594
[5.x] Add cache-control header to cached content #11430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
indykoning
wants to merge
10
commits into
statamic:5.x
Choose a base branch
from
indykoning:feature/cache-control-header
base: 5.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 6 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
63cfde3
Add cache-control header to cached content
indykoning 94db5ba
Added request import
indykoning 5774a8b
Removed duplicate response import
indykoning 504c0ed
Fix linting
indykoning cc9f37f
Update config
indykoning 3c88620
Run isNotModified check
indykoning 613b87d
Check getContent before setting etag
indykoning 3da5972
Fix linting
indykoning 2ffe1cd
Added check to only execute on macrod response
indykoning 2a41ca2
Merge branch '5.x' into feature/cache-control-header
indykoning File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a check from the Symfony response: https://github.com/symfony/symfony/blob/b5b0cbf0acb520629cc72532f99728e31992a55f/src/Symfony/Component/HttpFoundation/Response.php#L1113
It checks the etags on the request and response to determine if the local cache is still valid after the expiration time.
If it is, it will empty the response body and set the response code to 304 Not Modified. Saving the (Kilo)bytes from having to be downloaded again if they haven't changed.
Laravel also has a middleware that does this https://github.com/laravel/framework/blob/12.x/src/Illuminate/Http/Middleware/CheckResponseForModifications.php however it is not loaded by default.
It causes no issues if the check is called multiple times.