Add NICE and IONICE into distroless image#883
Merged
Conversation
hossainemruz
changed the title
NICE and IONICE into distroless imageNICE and IONICE into distroless image
tamalsaha
reviewed
Aug 30, 2019
hossainemruz
changed the title
NICE and IONICE into distroless imageNICE and IONICE into distroless image
tamalsaha
approved these changes
Sep 2, 2019
Codecov Report
@@ Coverage Diff @@
## master #883 +/- ##
=========================================
Coverage ? 32.21%
=========================================
Files ? 13
Lines ? 1279
Branches ? 0
=========================================
Hits ? 412
Misses ? 798
Partials ? 69Continue to review full report at Codecov.
|
tamalsaha
reviewed
Sep 2, 2019
| COPY bin/{ARG_OS}_{ARG_ARCH}/{ARG_BIN} /{ARG_BIN} | ||
|
|
||
| # Copy "nice" and "ionice". | ||
| COPY --from=0 /usr/bin/nice /bin/nice |
Member
There was a problem hiding this comment.
Did we need this? Isn't nice and ionice already installed in debian:stretch ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #882
WONT WORK FOR ARM IMAGES