Skip to content

Don't use priority class when operator namespace is not kube-system #666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tamalsaha merged 1 commit into from
Feb 4, 2019
Merged

Don't use priority class when operator namespace is not kube-system #666

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion hack/deploy/operator.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ spec:
tolerations:
- key: CriticalAddonsOnly
operator: Exists
priorityClassName: system-cluster-critical
priorityClassName: ${STASH_PRIORITY_CLASS}
---
# kube lacks the service serving cert signer, so provide a manual secret for it
apiVersion: v1
Expand Down
5 changes: 5 additions & 0 deletions hack/deploy/stash.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,7 @@ export STASH_UNINSTALL=0
export STASH_PURGE=0
export STASH_BYPASS_VALIDATING_WEBHOOK_XRAY=false
export STASH_USE_KUBEAPISERVER_FQDN_FOR_AKS=true
export STASH_PRIORITY_CLASS=system-cluster-critical

export SCRIPT_LOCATION="curl -fsSL https://raw.githubusercontent.com/appscode/stash/0.8.2/"
if [[ "$APPSCODE_ENV" == "dev" ]]; then
Expand Down Expand Up @@ -325,6 +326,10 @@ done

export PROMETHEUS_NAMESPACE=${PROMETHEUS_NAMESPACE:-$STASH_NAMESPACE}

if [ "$STASH_NAMESPACE" != "kube-system" ]; then
export STASH_PRIORITY_CLASS=""
fi

if [ "$STASH_UNINSTALL" -eq 1 ]; then
# delete webhooks and apiservices
kubectl delete validatingwebhookconfiguration -l app=stash || true
Expand Down