Warning Backup Job Creation Failed: must be no more than 63 characters

[clayrisser]

I am getting the following error when trying to backup a kubedb postgres with stash. It seems that the name it gives the job is not truncated.

Name:         postgres-siliconhills-postgres-postgres-postgres-1571016363
Namespace:    siliconhills-postgres
Labels:       app.kubernetes.io/component=stash-backup
              app.kubernetes.io/managed-by=stash.appscode.com
              stash.appscode.com/backup-configuration=postgres-siliconhills-postgres-postgres-postgres
Annotations:  <none>
API Version:  stash.appscode.com/v1beta1
Kind:         BackupSession
Metadata:
  Creation Timestamp:  2019-10-14T01:26:03Z
  Generation:          1
  Owner References:
    API Version:           stash.appscode.com/v1beta1
    Block Owner Deletion:  false
    Kind:                  BackupConfiguration
    Name:                  postgres-siliconhills-postgres-postgres-postgres
    UID:                   c94252a9-a04d-4c5e-8c84-4852f8835a47
  Resource Version:        141135
  Self Link:               /apis/stash.appscode.com/v1beta1/namespaces/siliconhills-postgres/backupsessions/postgres-siliconhills-postgres-postgres-postgres-1571016363
  UID:                     7fdafd61-b40f-40e0-a871-d2245aa6ebbb
Spec:
  Backup Configuration:
    Name:  postgres-siliconhills-postgres-postgres-postgres
Status:
  Phase:  Failed
Events:
  Type     Reason                      Age   From                      Message
  ----     ------                      ----  ----                      -------
  Warning  Backup Job Creation Failed  56s   BackupSession Controller  failed to create backup job for BackupSession siliconhills-postgres/postgres-siliconhills-postgres-postgres-postgres-1571016363. Reason: Job.batch "stash-backup-postgres-siliconhills-postgres-postgres-postgres-1571016363" is invalid: spec.template.labels: Invalid value: "stash-backup-postgres-siliconhills-postgres-postgres-postgres-1571016363": must be no more than 63 characters
  Warning  BackupSession Failed        56s   BackupSession Controller  Backup session failed to complete. Reason: Job.batch "stash-backup-postgres-siliconhills-postgres-postgres-postgres-1571016363" is invalid: spec.template.labels: Invalid value: "stash-backup-postgres-siliconhills-postgres-postgres-postgres-1571016363": must be no more than 63 characters

[tamalsaha]

This is a hard limit of k8s side, I believe. We need to find a way to trim the name.

[clayrisser]

@tamalsaha where is the name getting generated? Usually in my helm charts I truncate the name to 63 characters.

{{- printf "%s-%s" .Release.Name $name | trunc 63 | trimSuffix "-" }}

[hossainemruz]

xref: #840

[zarbis]

Getting same problem with BackupBlueprint. My setup is as follows:

         deployment/        ${appname}
         mongodb/           ${appname}-mongodb

Which results in generating:

         appbinding/        ${appname}-mongodb
backupconfiguration/mongodb-${appname}-mongodb
      backupsession/mongodb-${appname}-mongodb-1572004805
   pod/stash-backup-mongodb-${appname}-mongodb-1572004805

My proposals on shortening names would be:

1. Drop {{ dbType }} (e.g. mongodb-) prefix. Database cannot have same Service name as application, so it's suffixed with something like -mysql or -db. No confusion with application's PVC backup could be made. Also, in case of multiple DBs their names will be distinguished for the same reason as above.
2. stash-backup- prefix could be shortened to either stash- or backup-
3. kubectl-stash trigger adds shorter suffixes like -6n7p5 instead of timestamp